Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2684783003: Refactor ConstantSystem (Closed)

Created:
3 years, 10 months ago by Johnni Winther
Modified:
3 years, 10 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Refactor ConstantSystem - to prepare for kernel based implementation R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/a2b0a1bc1bcd9bd9af77ce6f40267016fed74e03

Patch Set 1 #

Patch Set 2 : Rebased #

Total comments: 4

Patch Set 3 : Updated cf. comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+156 lines, -86 lines) Patch
M pkg/compiler/lib/src/common/backend_api.dart View 1 2 1 chunk +13 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/compile_time_constants.dart View 4 chunks +17 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/constant_system_dart.dart View 3 chunks +18 lines, -12 lines 0 comments Download
M pkg/compiler/lib/src/constants/constant_system.dart View 2 chunks +16 lines, -12 lines 0 comments Download
M pkg/compiler/lib/src/constants/evaluation.dart View 2 chunks +5 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/constants/expressions.dart View 3 chunks +10 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 1 chunk +23 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend_helpers.dart View 1 chunk +8 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/constant_system_javascript.dart View 6 chunks +25 lines, -41 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/custom_elements_analysis.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/lookup_map_analysis.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart View 1 2 chunks +4 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/constant_expression_evaluate_test.dart View 3 chunks +10 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/mock_libraries.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
Johnni Winther
3 years, 10 months ago (2017-02-08 14:23:16 UTC) #2
Johnni Winther
ping
3 years, 10 months ago (2017-02-09 10:33:20 UTC) #3
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/2684783003/diff/20001/pkg/compiler/lib/src/common/backend_api.dart File pkg/compiler/lib/src/common/backend_api.dart (right): https://codereview.chromium.org/2684783003/diff/20001/pkg/compiler/lib/src/common/backend_api.dart#newcode222 pkg/compiler/lib/src/common/backend_api.dart:222: /// Returns the field of the constant symbol ...
3 years, 10 months ago (2017-02-09 20:20:30 UTC) #4
Siggi Cherem (dart-lang)
https://codereview.chromium.org/2684783003/diff/20001/pkg/compiler/lib/src/js_backend/constant_system_javascript.dart File pkg/compiler/lib/src/js_backend/constant_system_javascript.dart (left): https://codereview.chromium.org/2684783003/diff/20001/pkg/compiler/lib/src/js_backend/constant_system_javascript.dart#oldcode418 pkg/compiler/lib/src/js_backend/constant_system_javascript.dart:418: fields[field] = argument; (btw, much better now that we ...
3 years, 10 months ago (2017-02-09 20:22:20 UTC) #5
Johnni Winther
https://codereview.chromium.org/2684783003/diff/20001/pkg/compiler/lib/src/common/backend_api.dart File pkg/compiler/lib/src/common/backend_api.dart (right): https://codereview.chromium.org/2684783003/diff/20001/pkg/compiler/lib/src/common/backend_api.dart#newcode222 pkg/compiler/lib/src/common/backend_api.dart:222: /// Returns the field of the constant symbol implementation ...
3 years, 10 months ago (2017-02-10 09:22:11 UTC) #6
Johnni Winther
3 years, 10 months ago (2017-02-10 09:22:15 UTC) #7
Johnni Winther
3 years, 10 months ago (2017-02-10 09:30:23 UTC) #9
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
a2b0a1bc1bcd9bd9af77ce6f40267016fed74e03 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698