Use CodeSourceMap for stack traces (still JIT only).

Use CodeSourceMap for stack traces (still JIT only).

R=fschneider@google.com

Committed: https://github.com/dart-lang/sdk/commit/7d2e6b161516fe4dfe09563c762b0ff19c9a705e

[rmacnak, 2017-02-08 00:02:04]

rmacnak@google.com changed reviewers:
+ fschneider@google.com

[Florian Schneider, 2017-02-08 18:55:20]

Lgtm

https://codereview.chromium.org/2684763002/diff/1/runtime/vm/code_descriptors.h
File runtime/vm/code_descriptors.h (right):

https://codereview.chromium.org/2684763002/diff/1/runtime/vm/code_descriptors...
runtime/vm/code_descriptors.h:143: // A CodeSourceMap maps from pc offsets to a
stack inlined functions and their
stack *of* inlined

https://codereview.chromium.org/2684763002/diff/1/runtime/vm/code_descriptors...
runtime/vm/code_descriptors.h:186: // THR_Print(" Position %ld\n", pos.value());
Remove debug printing.

https://codereview.chromium.org/2684763002/diff/1/runtime/vm/code_descriptors...
runtime/vm/code_descriptors.h:203: // THR_Print(" Push %" Pd "\n", inline_id);
Remove debug printing

https://codereview.chromium.org/2684763002/diff/1/runtime/vm/code_descriptors...
runtime/vm/code_descriptors.h:215: // THR_Print(" Pop\n");
Remove debug printing.

https://codereview.chromium.org/2684763002/diff/1/runtime/vm/object.h
File runtime/vm/object.h (right):

https://codereview.chromium.org/2684763002/diff/1/runtime/vm/object.h#newcode...
runtime/vm/object.h:4790: // sample). Callers with a return address should
subtract one.
Subtracting one from from pc_offset is a bit subtle. Maybe it would be better to
have two functions: GetInlinedFunctionsAtReturnAddress and
GetInlinedFunctionsAtPc?

[rmacnak, 2017-02-08 19:24:27]

https://codereview.chromium.org/2684763002/diff/1/runtime/vm/code_descriptors.h
File runtime/vm/code_descriptors.h (right):

https://codereview.chromium.org/2684763002/diff/1/runtime/vm/code_descriptors...
runtime/vm/code_descriptors.h:143: // A CodeSourceMap maps from pc offsets to a
stack inlined functions and their
On 2017/02/08 18:55:20, Florian Schneider wrote:
> stack *of* inlined

Done.

https://codereview.chromium.org/2684763002/diff/1/runtime/vm/code_descriptors...
runtime/vm/code_descriptors.h:186: // THR_Print(" Position %ld\n", pos.value());
On 2017/02/08 18:55:20, Florian Schneider wrote:
> Remove debug printing.

Done.

https://codereview.chromium.org/2684763002/diff/1/runtime/vm/object.h
File runtime/vm/object.h (right):

https://codereview.chromium.org/2684763002/diff/1/runtime/vm/object.h#newcode...
runtime/vm/object.h:4790: // sample). Callers with a return address should
subtract one.
On 2017/02/08 18:55:20, Florian Schneider wrote:
> Subtracting one from from pc_offset is a bit subtle. Maybe it would be better
to
> have two functions: GetInlinedFunctionsAtReturnAddress and
> GetInlinedFunctionsAtPc?
> 

Added GetInlinedFunctionsAtReturnAddress and switched the stack trace builder to
use it. Leaving the profiler as always using GetInlinedFunctionsAtPc because it
has its own cache based on instruction addresses

[rmacnak, 2017-02-08 19:31:52]

Description was changed from

==========
Use CodeSourceMap for stack traces (still JIT only).
==========

to

==========
Use CodeSourceMap for stack traces (still JIT only).

R=fschneider@google.com

Committed:
https://github.com/dart-lang/sdk/commit/7d2e6b161516fe4dfe09563c762b0ff19c9a705e
==========

[rmacnak, 2017-02-08 19:31:53]

Committed patchset #2 (id:20001) manually as
7d2e6b161516fe4dfe09563c762b0ff19c9a705e (presubmit successful).