Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 268473004: one valgrind.supp to rule them all. (Closed)

Created:
6 years, 7 months ago by bsalomon
Modified:
6 years, 7 months ago
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

one valgrind.supp to rule them all. Committed: http://code.google.com/p/skia/source/detail?r=14487

Patch Set 1 #

Patch Set 2 : incorporate Issue 254283006 #

Total comments: 4

Patch Set 3 : Address nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -539 lines) Patch
D bench/valgrind.supp View 1 chunk +0 lines, -109 lines 0 comments Download
D gm/valgrind.supp View 1 chunk +0 lines, -180 lines 0 comments Download
D tests/valgrind.supp View 1 chunk +0 lines, -200 lines 0 comments Download
M tools/valgrind.supp View 1 2 3 chunks +71 lines, -50 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
mtklein
LGTM, with nits https://codereview.chromium.org/268473004/diff/20001/tools/valgrind.supp File tools/valgrind.supp (right): https://codereview.chromium.org/268473004/diff/20001/tools/valgrind.supp#newcode1 tools/valgrind.supp:1: # Pass this file to Valgrind ...
6 years, 7 months ago (2014-04-30 20:48:24 UTC) #1
bsalomon
I think I successfully merged all the suppressions from our various valgrind.supp files.
6 years, 7 months ago (2014-04-30 20:48:50 UTC) #2
bsalomon
https://codereview.chromium.org/268473004/diff/20001/tools/valgrind.supp File tools/valgrind.supp (right): https://codereview.chromium.org/268473004/diff/20001/tools/valgrind.supp#newcode1 tools/valgrind.supp:1: # Pass this file to Valgrind with "--suppressions=tests/valgrind.supp" On ...
6 years, 7 months ago (2014-04-30 20:50:14 UTC) #3
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 7 months ago (2014-04-30 20:52:03 UTC) #4
bsalomon
The CQ bit was unchecked by bsalomon@google.com
6 years, 7 months ago (2014-04-30 20:52:10 UTC) #5
bsalomon
I almost committed this but wasn't sure what would happen if this landed before the ...
6 years, 7 months ago (2014-04-30 20:53:21 UTC) #6
borenet
On 2014/04/30 20:53:21, bsalomon wrote: > I almost committed this but wasn't sure what would ...
6 years, 7 months ago (2014-04-30 20:59:12 UTC) #7
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 7 months ago (2014-04-30 21:03:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/268473004/40001
6 years, 7 months ago (2014-04-30 21:03:45 UTC) #9
commit-bot: I haz the power
6 years, 7 months ago (2014-04-30 21:10:17 UTC) #10
Message was sent while issue was closed. 
Change committed as 14487

Powered by Google App Engine
This is Rietveld 408576698