Remove LauncherItemController::Launch, cleanup.

chrome/browser/ui/ash/launcher/chrome_launcher_controller.h

Index: chrome/browser/ui/ash/launcher/chrome_launcher_controller.h
diff --git a/chrome/browser/ui/ash/launcher/chrome_launcher_controller.h b/chrome/browser/ui/ash/launcher/chrome_launcher_controller.h
index b40a511a4f6879dca776b8384260f003b8049906..43aeacfa60af76c65ab5e92786d303f92afda179 100644
--- a/chrome/browser/ui/ash/launcher/chrome_launcher_controller.h
+++ b/chrome/browser/ui/ash/launcher/chrome_launcher_controller.h
@@ -135,18 +135,13 @@ class ChromeLauncherController : public ash::mojom::ShelfObserver,
   virtual bool IsPlatformApp(ash::ShelfID id) = 0;
 
   // Opens a new instance of the application identified by |app_id|.
+  // The |launch_id| is used to support multiple shelf items per app.
   // Used by the app-list, and by pinned-app shelf items.
   void LaunchApp(const std::string& app_id,
+                 const std::string& launch_id,

[James Cook, 2017/02/08 17:37:00]

I think this would be better if it took an AppLauncherId (from
chrome_launcher_prefs.h, though it really ought to be in chrome_launcher_types.h
or its own file). That class encapsulates both app_id and launch_id so you don't
have to pass two adjacent strings as arguments.

[khmel, 2017/02/08 17:41:27]

+1 to this. There is also CL: https://codereview.chromium.org/2684853002/ where
AppLauncherId is moved to separate file.

[msw, 2017/02/09 00:42:00]

Done.

                  ash::LaunchSource source,
                  int event_flags);
 
-  // As above but includes |launch_id|, an id that can be passed to an app when
-  // launched in order to support multiple shelf items per app.
-  void LaunchAppWithLaunchId(const std::string& app_id,
-                             const std::string& launch_id,
-                             ash::LaunchSource source,
-                             int event_flags);
-
   // If |app_id| is running, reactivates the app's most recently active window,
   // otherwise launches and activates the app.
   // Used by the app-list, and by pinned-app shelf items.