chrome/browser/ui/ash/launcher/chrome_launcher_controller_mus.cc - Issue 2684723003: Remove LauncherItemController::Launch, cleanup.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/ash/launcher/chrome_launcher_controller_mus.cc

Issue 2684723003: Remove LauncherItemController::Launch, cleanup. (Closed)

Patch Set: Use AppLauncherId Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/ash/launcher/chrome_launcher_controller_mus.cc

diff --git a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_mus.cc b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_mus.cc

index 3293679bcfcda9c3e0fce01ae768a53e8d900f23..d5948ddc48fcfe7a88755f0b50ddbc4aee49c3ff 100644

--- a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_mus.cc

+++ b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_mus.cc

@@ -35,7 +35,8 @@ class ChromeShelfItemDelegate : public ash::mojom::ShelfItemDelegate {

private:

// ash::mojom::ShelfItemDelegate:

void LaunchItem() override {

- controller_->LaunchApp(app_id_, ash::LAUNCH_FROM_UNKNOWN, ui::EF_NONE);

+ controller_->LaunchApp(ash::launcher::AppLauncherId(app_id_),

+ ash::LAUNCH_FROM_UNKNOWN, ui::EF_NONE);

}

void ExecuteCommand(uint32_t command_id, int32_t event_flags) override {

NOTIMPLEMENTED();