Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Side by Side Diff: docs/code_reviews.md

Issue 2684693007: Fix typo in code review documentation. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Code Reviews 1 # Code Reviews
2 2
3 Code reviews are a central part of developing high-quality code for Chromium. 3 Code reviews are a central part of developing high-quality code for Chromium.
4 All changes must be reviewed. 4 All changes must be reviewed.
5 5
6 The bigger patch-upload-and-land process is covered in more detail the 6 The bigger patch-upload-and-land process is covered in more detail the
7 [contributing code](https://www.chromium.org/developers/contributing-code) 7 [contributing code](https://www.chromium.org/developers/contributing-code)
8 page. 8 page.
9 9
10 # Code review policies 10 # Code review policies
(...skipping 154 matching lines...) Expand 10 before | Expand all | Expand 10 after
165 # You can include comments like this. 165 # You can include comments like this.
166 a@chromium.org 166 a@chromium.org
167 b@chromium.org # Only for the frobinator. 167 b@chromium.org # Only for the frobinator.
168 ``` 168 ```
169 169
170 A `*` indicates that all committers are owners: 170 A `*` indicates that all committers are owners:
171 ``` 171 ```
172 * 172 *
173 ``` 173 ```
174 174
175 The text `set noparent` it will stop owner propagation from parent directories. 175 The text `set noparent` will stop owner propagation from parent directories.
176 This is used for specialized code. In this example, only the two listed people 176 This is used for specialized code. In this example, only the two listed people
177 are owners: 177 are owners:
178 ``` 178 ```
179 set noparent 179 set noparent
180 a@chromium.org 180 a@chromium.org
181 b@chromium.org 181 b@chromium.org
182 ``` 182 ```
183 183
184 The `per-file` directive allows owners to be added that apply only to files 184 The `per-file` directive allows owners to be added that apply only to files
185 matching a pattern. In this example, owners from the parent directiory 185 matching a pattern. In this example, owners from the parent directiory
186 apply, plus one person for some classes of files, and all committers are 186 apply, plus one person for some classes of files, and all committers are
187 owners for the readme: 187 owners for the readme:
188 ``` 188 ```
189 per-file foo_bar.cc=a@chromium.org 189 per-file foo_bar.cc=a@chromium.org
190 per-file foo.*=a@chromium.org 190 per-file foo.*=a@chromium.org
191 191
192 per-file readme.txt=* 192 per-file readme.txt=*
193 ``` 193 ```
194 194
195 Other `OWNERS` files can be included by reference by listing the path to the 195 Other `OWNERS` files can be included by reference by listing the path to the
196 file with `file://...`. This example indicates that only the people listed in 196 file with `file://...`. This example indicates that only the people listed in
197 `//ipc/SECURITY_OWNERS` can review the messages files: 197 `//ipc/SECURITY_OWNERS` can review the messages files:
198 ``` 198 ```
199 per-file *_messages*.h=set noparent 199 per-file *_messages*.h=set noparent
200 per-file *_messages*.h=file://ipc/SECURITY_OWNERS 200 per-file *_messages*.h=file://ipc/SECURITY_OWNERS
201 ``` 201 ```
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698