MD History: Remove list-container and list-behavior

chrome/browser/resources/md_history/app.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('md_history', function() {
   var lazyLoadPromise = null;
   function ensureLazyLoaded() {
     if (!lazyLoadPromise) {
       lazyLoadPromise = new Promise(function(resolve, reject) {
         Polymer.Base.importHref(
@@ skipping 158 matching lines @@
       this.showMenuPromo_ = false;
   },
 
   /**
    * Listens for history-item being selected or deselected (through checkbox)
    * and changes the view of the top toolbar.
    * @param {{detail: {countAddition: number}}} e
    */
   checkboxSelected: function(e) {
     var toolbar = /** @type {HistoryToolbarElement} */ (this.$.toolbar);
-    toolbar.count = /** @type {HistoryListContainerElement} */ (this.$.history)
+    toolbar.count = /** @type {HistoryListElement} */ (this.$.history)
                         .getSelectedItemCount();
   },
 
   /**
    * Listens for call to cancel selection and loops through all items to set
    * checkbox to be unselected.
    * @private
    */
   unselectAll: function() {
-    var listContainer =
-        /** @type {HistoryListContainerElement} */ (this.$.history);
+    var list = /** @type {HistoryListElement} */ (this.$.history);
     var toolbar = /** @type {HistoryToolbarElement} */ (this.$.toolbar);
-    listContainer.unselectAllItems(toolbar.count);
+    list.unselectAllItems();
     toolbar.count = 0;
   },
 
   deleteSelected: function() {
     this.$.history.deleteSelectedWithPrompt();
   },
 
   /**
    * @param {HistoryQuery} info An object containing information about the
    *    query.
    * @param {!Array<HistoryEntry>} results A list of results.
    */
   historyResult: function(info, results) {
     this.set('queryState_.querying', false);
     this.set('queryResult_.info', info);
     this.set('queryResult_.results', results);
-    var listContainer =
-        /** @type {HistoryListContainerElement} */ (this.$['history']);
-    listContainer.historyResult(info, results);
+    var list = /** @type {HistoryListElement} */ (this.$['history']);
+    list.historyResult(info, results);
   },
 
   /**
    * Shows and focuses the search bar in the toolbar.
    */
   focusToolbarSearchField: function() {
     this.$.toolbar.showSearchField();
   },
 
   /**
@@ skipping 13 matching lines @@
     }
   },
 
   /**
    * @param {Event} e
    * @private
    */
   onCommand_: function(e) {
     if (e.command.id == 'find-command' || e.command.id == 'slash-command')
       this.focusToolbarSearchField();
-    else if (e.command.id == 'delete-command')

[calamity, 2017/02/21 02:40:06]

nit: Did this change for a reason?

[tsergeant, 2017/02/21 23:24:12]

Oh, just me messing up git.

Done.

[Dan Beam, 2017/02/21 23:26:55]

fwiw: I liked this ^ version better.

+    if (e.command.id == 'delete-command')
       this.deleteSelected();
   },
 
   /**
    * @param {!Array<!ForeignSession>} sessionList Array of objects describing
    *     the sessions from other devices.
    */
   setForeignSessions: function(sessionList) {
     this.set('queryResult_.sessionList', sessionList);
   },
@@ skipping 48 matching lines @@
   selectedPageChanged_: function() {
     this.unselectAll();
     this.historyViewChanged_();
   },
 
   /** @private */
   historyViewChanged_: function() {
     // This allows the synced-device-manager to render so that it can be set as
     // the scroll target.
     requestAnimationFrame(function() {
-      md_history.ensureLazyLoaded().then(function() {
-        // <iron-pages> can occasionally end up with no item selected during
-        // tests.
-        if (!this.$.content.selectedItem)
-          return;

[calamity, 2017/02/21 02:40:06]

Do we still need this for synced-device-manager? I'm pretty happy to remove this
and see if tests start flaking.

[tsergeant, 2017/02/21 23:24:12]

I'm pretty sure that the new version of this function is correct and the tests
seem happy enough with it.

scrollTarget is now set through data binding. We still need the rAF ->
scrollHandler() to ensure the shadow updates correctly when switching between
pages.

-        this.scrollTarget =
-            this.$.content.selectedItem.getContentScrollTarget();
-        this._scrollHandler();
-      }.bind(this));
+      this._scrollHandler();
     }.bind(this));
     this.recordHistoryPageView_();
   },
 
   /** @private */
   hasDrawerChanged_: function() {
     var drawer = /** @type {?CrDrawerElement} */ (this.$.drawer.getIfExists());
     if (!this.hasDrawer_ && drawer && drawer.open)
       drawer.closeDrawer();
   },
@@ skipping 31 matching lines @@
       default:
         histogramValue = HistoryPageViewHistogram.HISTORY;
         break;
     }
 
     md_history.BrowserService.getInstance().recordHistogram(
         'History.HistoryPageView', histogramValue,
         HistoryPageViewHistogram.END);
   },
 });