Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7706)

Unified Diff: chrome/browser/resources/PRESUBMIT.py

Issue 2684673002: MD WebUI: run vulcanize tests on PRESUBMIT (Closed)
Patch Set: -prints Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/PRESUBMIT.py
diff --git a/chrome/browser/resources/PRESUBMIT.py b/chrome/browser/resources/PRESUBMIT.py
index 9dac91943826e66a0467667a4b2ac99ba5e8b82b..38260bc8190de24192f79c856cd36c6c25f30f4a 100644
--- a/chrome/browser/resources/PRESUBMIT.py
+++ b/chrome/browser/resources/PRESUBMIT.py
@@ -91,12 +91,26 @@ def IsBoolean(new_content_lines, metric_name, input_api):
any(input_api.re.search(type_re, match.group(i)) for i in (1, 3)))
+def RunVulcanizeTests(input_api, output_api):
+ presubmit_path = input_api.PresubmitLocalPath()
+ tests = [input_api.os_path.join(presubmit_path, 'vulcanize_gn_test.py')]
+ return input_api.canned_checks.RunUnitTests(input_api, output_api, tests)
+
+
+def _CheckChangeOnUploadOrCommit(input_api, output_api):
+ results = CheckUserActionUpdate(input_api, output_api, ACTION_XML_PATH)
+ affected = input_api.AffectedFiles()
+ if any(f for f in affected if f.LocalPath().endswith('vulcanize_gn.py')):
+ results += RunVulcanizeTests(input_api, output_api)
+ return results
+
+
def CheckChangeOnUpload(input_api, output_api):
- return CheckUserActionUpdate(input_api, output_api, ACTION_XML_PATH)
+ return _CheckChangeOnUploadOrCommit(input_api, output_api)
def CheckChangeOnCommit(input_api, output_api):
- return CheckUserActionUpdate(input_api, output_api, ACTION_XML_PATH)
+ return _CheckChangeOnUploadOrCommit(input_api, output_api)
def PostUploadHook(cl, change, output_api):
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698