Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1387)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py

Issue 2684663003: WPT importer: List directory owners in CL description. (Closed)
Patch Set: Update change to not change TBR line. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py
index 45b6bb9cf25469a3c5eb75f71437e0d456cae107..be0fb3e33ba35c73a51b144d3ed363292868271a 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py
@@ -76,7 +76,7 @@ class TestImporterTest(LoggingTestCase):
host = MockHost()
host.executive = MockExecutive(output='Last commit message\n\n')
importer = TestImporter(host)
- description = importer._cl_description()
+ description = importer._cl_description(directory_owners={})
self.assertEqual(
description,
('Last commit message\n\n'
@@ -91,7 +91,7 @@ class TestImporterTest(LoggingTestCase):
importer.host.environ['BUILDBOT_MASTERNAME'] = 'my.master'
importer.host.environ['BUILDBOT_BUILDERNAME'] = 'b'
importer.host.environ['BUILDBOT_BUILDNUMBER'] = '123'
- description = importer._cl_description()
+ description = importer._cl_description(directory_owners={})
self.assertEqual(
description,
('Last commit message\n'
@@ -104,13 +104,33 @@ class TestImporterTest(LoggingTestCase):
host = MockHost()
host.executive = MockExecutive(output='Summary\n\nNOEXPORT=true\n\n')
importer = TestImporter(host)
- description = importer._cl_description()
+ description = importer._cl_description(directory_owners={})
self.assertEqual(
description,
('Summary\n\n'
'TBR=qyearsley@chromium.org\n'
'NOEXPORT=true'))
+ def test_cl_description_with_directory_owners(self):
+ host = MockHost()
+ host.executive = MockExecutive(output='Last commit message\n\n')
+ importer = TestImporter(host)
+ description = importer._cl_description(directory_owners={
+ 'someone@chromium.org': ['external/wpt/foo', 'external/wpt/bar'],
+ 'someone-else@chromium.org': ['external/wpt/baz'],
+ })
+ self.assertEqual(
+ description,
+ ('Last commit message\n\n'
+ 'Directory owners for changes in this CL:\n'
+ 'someone-else@chromium.org:\n'
+ ' external/wpt/baz\n'
+ 'someone@chromium.org:\n'
+ ' external/wpt/foo\n'
+ ' external/wpt/bar\n\n'
+ 'TBR=qyearsley@chromium.org\n'
+ 'NOEXPORT=true'))
+
def test_generate_manifest_command_not_found(self):
# If we're updating csswg-test, then the manifest file won't be found.
host = MockHost()
« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698