Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Unified Diff: third_party/WebKit/Source/core/html/track/vtt/VTTRegion.h

Issue 2684633005: Move VTTRegion Timers to TaskRunnerTimer (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/track/vtt/VTTRegion.h
diff --git a/third_party/WebKit/Source/core/html/track/vtt/VTTRegion.h b/third_party/WebKit/Source/core/html/track/vtt/VTTRegion.h
index 4ec0baf723c847f19d727c115bb4ef4ad5ed9606..1962f98b5fa4a61d75605752851017228ba01aa7 100644
--- a/third_party/WebKit/Source/core/html/track/vtt/VTTRegion.h
+++ b/third_party/WebKit/Source/core/html/track/vtt/VTTRegion.h
@@ -102,6 +102,8 @@ class VTTRegion final : public GarbageCollectedFinalized<VTTRegion>,
void prepareRegionDisplayTree();
+ void prepareScrollTimer(Document&);
+
// The timer is needed to continue processing when cue scrolling ended.
void startTimer();
void stopTimer();
@@ -150,7 +152,7 @@ class VTTRegion final : public GarbageCollectedFinalized<VTTRegion>,
// soon as the animation for rolling out one line has finished, but
// currently it is used also for non-scrolling regions to use a single
// code path.
- Timer<VTTRegion> m_scrollTimer;
+ std::unique_ptr<TaskRunnerTimer<VTTRegion>> m_scrollTimer;
haraken 2017/02/08 11:49:40 Can we just use TaskRunnerTimer<VTTRegion> ?
maksims (do not use this acc) 2017/02/08 13:02:05 Otherwise I cannot provide TaskRunnerTimer with ap
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698