Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(589)

Unified Diff: third_party/WebKit/Source/platform/heap/PersistentNode.cpp

Issue 2684633004: Remove orphaned pages from Oilpan (Closed)
Patch Set: temp Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/heap/PersistentNode.cpp
diff --git a/third_party/WebKit/Source/platform/heap/PersistentNode.cpp b/third_party/WebKit/Source/platform/heap/PersistentNode.cpp
index 3cb1821980c5530b49d00f6458b7c736b5d57df1..4c09dc74b3512bb05a78ed01a95d05a4deb3d5c8 100644
--- a/third_party/WebKit/Source/platform/heap/PersistentNode.cpp
+++ b/third_party/WebKit/Source/platform/heap/PersistentNode.cpp
@@ -165,10 +165,6 @@ void CrossThreadPersistentRegion::prepareForThreadStateTermination(
continue;
BasePage* page = pageFromObject(rawObject);
ASSERT(page);
- // The main thread will upon detach just mark its heap pages as orphaned,
- // but not invalidate its CrossThreadPersistent<>s.
- if (page->orphaned())
- continue;
if (page->arena()->getThreadState() == threadState) {
persistent->clear();
ASSERT(slots->m_slot[i].isUnused());
« no previous file with comments | « third_party/WebKit/Source/platform/heap/PagePool.cpp ('k') | third_party/WebKit/Source/platform/heap/ThreadState.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698