Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3772)

Unified Diff: chrome/browser/resources/md_history/app.js

Issue 2684493002: MD History: Delete Grouped History (Closed)
Patch Set: Rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/md_history/app.js
diff --git a/chrome/browser/resources/md_history/app.js b/chrome/browser/resources/md_history/app.js
index b67bf99d2671b9ac5f996c6674e9b41a0499ef1d..afe3b04132b292737fe7af6cf43828280e16731e 100644
--- a/chrome/browser/resources/md_history/app.js
+++ b/chrome/browser/resources/md_history/app.js
@@ -33,12 +33,6 @@ Polymer({
observer: 'selectedPageChanged_',
},
- // Whether domain-grouped history is enabled.
- grouped_: {
- type: Boolean,
- reflectToAttribute: true,
- },
-
/** @type {!QueryResult} */
queryResult_: {
type: Object,
@@ -106,8 +100,6 @@ Polymer({
/** @override */
attached: function() {
- this.grouped_ = loadTimeData.getBoolean('groupByDomain');
-
cr.ui.decorate('command', cr.ui.Command);
this.boundOnCanExecute_ = this.onCanExecute_.bind(this);
this.boundOnCommand_ = this.onCommand_.bind(this);
@@ -234,9 +226,6 @@ Polymer({
e = /** @type {cr.ui.CanExecuteEvent} */ (e);
switch (e.command.id) {
case 'find-command':
- case 'toggle-grouped':
- e.canExecute = true;
- break;
case 'slash-command':
e.canExecute = !this.$.toolbar.searchField.isSearchFocused();
break;
@@ -253,10 +242,8 @@ Polymer({
onCommand_: function(e) {
if (e.command.id == 'find-command' || e.command.id == 'slash-command')
this.focusToolbarSearchField();
- if (e.command.id == 'delete-command')
+ else if (e.command.id == 'delete-command')
this.deleteSelected();
- if (e.command.id == 'toggle-grouped')
- this.grouped_ = !this.grouped_;
},
/**
@@ -313,9 +300,7 @@ Polymer({
return hasSyncedResults && selectedPage != 'syncedTabs';
},
- /**
- * @private
- */
+ /** @private */
selectedPageChanged_: function() {
this.unselectAll();
this.historyViewChanged_();
@@ -377,17 +362,7 @@ Polymer({
HistoryPageViewHistogram.SIGNIN_PROMO;
break;
default:
- switch (this.queryState_.range) {
- case HistoryRange.ALL_TIME:
- histogramValue = HistoryPageViewHistogram.HISTORY;
- break;
- case HistoryRange.WEEK:
- histogramValue = HistoryPageViewHistogram.GROUPED_WEEK;
- break;
- case HistoryRange.MONTH:
- histogramValue = HistoryPageViewHistogram.GROUPED_MONTH;
- break;
- }
+ histogramValue = HistoryPageViewHistogram.HISTORY;
break;
}
« no previous file with comments | « chrome/browser/resources/md_history/app.html ('k') | chrome/browser/resources/md_history/compiled_resources2.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698