MD History: Delete Grouped History

chrome/browser/resources/md_history/app.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('md_history', function() {
   var lazyLoadPromise = null;
   function ensureLazyLoaded() {
     if (!lazyLoadPromise) {
       lazyLoadPromise = new Promise(function(resolve, reject) {
         Polymer.Base.importHref(
@@ skipping 15 matching lines @@
     Polymer.IronScrollTargetBehavior,
   ],
 
   properties: {
     // The id of the currently selected page.
     selectedPage_: {
       type: String,
       observer: 'selectedPageChanged_',
     },
 
-    // Whether domain-grouped history is enabled.
-    grouped_: {
-      type: Boolean,
-      reflectToAttribute: true,
-    },
-
     /** @type {!QueryResult} */
     queryResult_: {
       type: Object,
       value: function() {
         return {
           info: null,
           results: null,
           sessionList: null,
         };
       }
@@ skipping 47 matching lines @@
   },
 
   /** @private {?function(!Event)} */
   boundOnCanExecute_: null,
 
   /** @private {?function(!Event)} */
   boundOnCommand_: null,
 
   /** @override */
   attached: function() {
-    this.grouped_ = loadTimeData.getBoolean('groupByDomain');
-
     cr.ui.decorate('command', cr.ui.Command);
     this.boundOnCanExecute_ = this.onCanExecute_.bind(this);
     this.boundOnCommand_ = this.onCommand_.bind(this);
 
     document.addEventListener('canExecute', this.boundOnCanExecute_);
     document.addEventListener('command', this.boundOnCommand_);
   },
 
   /** @override */
   detached: function() {
@@ skipping 106 matching lines @@
   },
 
   /**
    * @param {Event} e
    * @private
    */
   onCanExecute_: function(e) {
     e = /** @type {cr.ui.CanExecuteEvent} */ (e);
     switch (e.command.id) {
       case 'find-command':
-      case 'toggle-grouped':
-        e.canExecute = true;
-        break;
       case 'slash-command':
         e.canExecute = !this.$.toolbar.searchField.isSearchFocused();
         break;
       case 'delete-command':
         e.canExecute = this.$.toolbar.count > 0;
         break;
     }
   },
 
   /**
    * @param {Event} e
    * @private
    */
   onCommand_: function(e) {
     if (e.command.id == 'find-command' || e.command.id == 'slash-command')
       this.focusToolbarSearchField();
     if (e.command.id == 'delete-command')

[Dan Beam, 2017/02/07 18:14:13]

nit: else if or switch()

       this.deleteSelected();
-    if (e.command.id == 'toggle-grouped')
-      this.grouped_ = !this.grouped_;
   },
 
   /**
    * @param {!Array<!ForeignSession>} sessionList Array of objects describing
    *     the sessions from other devices.
    */
   setForeignSessions: function(sessionList) {
     this.set('queryResult_.sessionList', sessionList);
   },
 
@@ skipping 36 matching lines @@
   /**
    * @param {boolean} hasSyncedResults
    * @param {string} selectedPage
    * @return {boolean} Whether the (i) synced results notice should be shown.
    * @private
    */
   showSyncNotice_: function(hasSyncedResults, selectedPage) {
     return hasSyncedResults && selectedPage != 'syncedTabs';
   },
 
-  /**
-   * @private
-   */
+  /** @private */
   selectedPageChanged_: function() {
     this.unselectAll();
     this.historyViewChanged_();
   },
 
   /** @private */
   historyViewChanged_: function() {
     // This allows the synced-device-manager to render so that it can be set as
     // the scroll target.
     requestAnimationFrame(function() {
@@ skipping 41 matching lines @@
   /** @private */
   recordHistoryPageView_: function() {
     var histogramValue = HistoryPageViewHistogram.END;
     switch (this.selectedPage_) {
       case 'syncedTabs':
         histogramValue = this.isUserSignedIn_ ?
             HistoryPageViewHistogram.SYNCED_TABS :
             HistoryPageViewHistogram.SIGNIN_PROMO;
         break;
       default:
-        switch (this.queryState_.range) {
-          case HistoryRange.ALL_TIME:
-            histogramValue = HistoryPageViewHistogram.HISTORY;
-            break;
-          case HistoryRange.WEEK:
-            histogramValue = HistoryPageViewHistogram.GROUPED_WEEK;
-            break;
-          case HistoryRange.MONTH:
-            histogramValue = HistoryPageViewHistogram.GROUPED_MONTH;
-            break;
-        }
+        histogramValue = HistoryPageViewHistogram.HISTORY;
         break;
     }
 
     md_history.BrowserService.getInstance().recordHistogram(
         'History.HistoryPageView', histogramValue,
         HistoryPageViewHistogram.END);
   },
 });