android_webview/BUILD.gn - Issue 2684433003: Files required by a service now listed in manifest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/BUILD.gn

Issue 2684433003: Files required by a service now listed in manifest. (Closed)

Patch Set: Addressed @boliu and @jam's comments. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: android_webview/BUILD.gn

diff --git a/android_webview/BUILD.gn b/android_webview/BUILD.gn

index 2d3b3cf0362330102d2a6cc3125814b6e3501036..9fc02d092b5cc4b6e51a982ce6a7a9996ce0005a 100644

--- a/android_webview/BUILD.gn

+++ b/android_webview/BUILD.gn

@@ -561,6 +561,7 @@ source_set("common") {

"//content",

"//content/public/app:both",

"//content/public/browser",

+ "//content/public/common:content_descriptor_keys",

"//content/public/common:service_names",

"//crypto",

"//gin",

« no previous file with comments | « no previous file | android_webview/lib/main/aw_main_delegate.cc » ('j') | base/android/apk_assets.cc » ('J')