content/app/DEPS - Issue 2684433003: Files required by a service now listed in manifest.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/app/DEPS

Issue 2684433003: Files required by a service now listed in manifest. (Closed)

Patch Set: Addressed @boliu and @jam's comments. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "+components/tracing",	2 "+components/tracing",

3 "+content",	3 "+content",

4 "+device/battery",	4 "+device/battery",

5 "+device/bluetooth",	5 "+device/bluetooth",

6 "+device/gamepad",	6 "+device/gamepad",

7 "+device/generic_sensor",	7 "+device/generic_sensor",

8 "+device/geolocation",	8 "+device/geolocation",

9 "+device/power_save_blocker",	9 "+device/power_save_blocker",

10 "+device/sensors",	10 "+device/sensors",

11 "+device/time_zone_monitor",	11 "+device/time_zone_monitor",

12 "+device/usb",	12 "+device/usb",

13 "+device/vibration",	13 "+device/vibration",

14 # For loading V8's initial snapshot from external files.	14 # For loading V8's initial snapshot from external files.

15 "+gin/public/isolate_holder.h",	15 "+gin/public/isolate_holder.h",

16 "+gin/public/snapshot_fd_data.h",	16 "+gin/public/snapshot_fd_data.h",

17 "+gin/v8_initializer.h",	17 "+gin/v8_initializer.h",

	18 "+services/service_manager/public/cpp",

18 ]	19 ]

OLD	NEW