Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 268443003: Make CanvasGradient.addColorStop throw TypeError for non-finite offsets (Closed)

Created:
6 years, 7 months ago by fs
Modified:
6 years, 7 months ago
Reviewers:
Justin Novosad
CC:
blink-reviews, arv+blink, blink-reviews-html_chromium.org, dglazkov+blink, Rik, adamk+blink_chromium.org, aandrey+blink_chromium.org, watchdog-blink-watchlist_google.com, Inactive
Visibility:
Public.

Description

Make CanvasGradient.addColorStop throw TypeError for non-finite offsets This aligns with the spec and Gecko. BUG=367648 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172988

Patch Set 1 #

Messages

Total messages: 5 (0 generated)
fs
Note: Upstream tests are incorrect (expect IndexSizeError), so they need to be fixed.
6 years, 7 months ago (2014-04-30 14:44:22 UTC) #1
Justin Novosad
On 2014/04/30 14:44:22, fs wrote: > Note: Upstream tests are incorrect (expect IndexSizeError), so they ...
6 years, 7 months ago (2014-04-30 14:53:30 UTC) #2
fs
The CQ bit was checked by fs@opera.com
6 years, 7 months ago (2014-04-30 14:56:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/268443003/1
6 years, 7 months ago (2014-04-30 14:58:47 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-04-30 15:07:18 UTC) #5
Message was sent while issue was closed.
Change committed as 172988

Powered by Google App Engine
This is Rietveld 408576698