Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1998)

Unified Diff: extensions/browser/api/BUILD.gn

Issue 2684393002: Update deps in extensions/browser/BUILD.gn to pass gn check. (Closed)
Patch Set: restrict visibility of new targets Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/BUILD.gn
diff --git a/extensions/browser/api/BUILD.gn b/extensions/browser/api/BUILD.gn
index 210a2ffc45a83ea77dc3f5d50d033acdc9ac364b..905313b9881892e9aa7760cc7ea962bb9b753c1d 100644
--- a/extensions/browser/api/BUILD.gn
+++ b/extensions/browser/api/BUILD.gn
@@ -76,10 +76,31 @@ source_set("api") {
deps = [
"//base:i18n",
+ "//components/keyed_service/content:content",
"//content/public/browser",
+ "//content/public/common",
+ "//device/base",
Devlin 2017/02/13 16:07:21 multiple entries for //device/base, //device/hid,
michaelpg 2017/02/13 21:08:42 oops, removed
+ "//device/hid",
+ "//device/usb",
+ "//extensions/browser:browser_sources",
+ "//extensions/browser/guest_view",
+ "//extensions/common",
+ "//extensions/common/api",
"//extensions/strings",
]
+ # TODO(michaelpg): Move these deps to the individual APIs that require them.
+ deps += [
+ "//components/onc",
+ "//components/storage_monitor",
+ "//device/base",
+ "//device/bluetooth",
+ "//device/hid",
+ "//device/power_save_blocker",
+ "//device/serial",
+ "//device/usb",
+ ]
+
if (is_chromeos) {
public_deps += [
"//extensions/browser/api/clipboard",
@@ -88,6 +109,8 @@ source_set("api") {
"//extensions/browser/api/vpn_provider",
"//extensions/browser/api/webcam_private",
]
+
+ deps += [ "//chromeos" ]
Devlin 2017/02/13 16:07:21 Do we need to depend on chromeos in non-chromeos b
michaelpg 2017/02/13 21:08:42 I don't think so, am I missing something? (This is
Devlin 2017/02/13 22:15:12 Whoops; my block-vision was off. Nvm.
}
}

Powered by Google App Engine
This is Rietveld 408576698