Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Unified Diff: chrome/browser/ui/views/passwords/credentials_item_view.h

Issue 2684343006: Make the account chooser and CVC dialog use the same icon with toolip for Views. (Closed)
Patch Set: move files Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/passwords/credentials_item_view.h
diff --git a/chrome/browser/ui/views/passwords/credentials_item_view.h b/chrome/browser/ui/views/passwords/credentials_item_view.h
index 83d2cfcb0e2f380c985efc2820e55345702663eb..240f71e0cd35df0aeae5b0366b8500406b16766f 100644
--- a/chrome/browser/ui/views/passwords/credentials_item_view.h
+++ b/chrome/browser/ui/views/passwords/credentials_item_view.h
@@ -8,7 +8,7 @@
#include "base/macros.h"
#include "base/memory/weak_ptr.h"
#include "chrome/browser/ui/passwords/account_avatar_fetcher.h"
-#include "ui/views/controls/button/label_button.h"
+#include "ui/views/controls/button/custom_button.h"
namespace autofill {
struct PasswordForm;
@@ -30,7 +30,7 @@ class Label;
// CredentialsItemView represents a credential view in the account chooser
// bubble.
class CredentialsItemView : public AccountAvatarFetcherDelegate,
- public views::LabelButton {
+ public views::CustomButton {
public:
CredentialsItemView(views::ButtonListener* button_listener,
const base::string16& upper_text,
@@ -51,12 +51,14 @@ class CredentialsItemView : public AccountAvatarFetcherDelegate,
int GetPreferredHeight() const;
private:
- // views::LabelButton:
+ // views::View:
gfx::Size GetPreferredSize() const override;
int GetHeightForWidth(int w) const override;
void Layout() override;
void OnPaint(gfx::Canvas* canvas) override;
+ void NotifyClick(const ui::Event& event) override;
msw 2017/02/15 21:06:37 nit: add |// views::CustomButton:| above this
vasilii 2017/02/16 14:28:06 It's obsolete code.
+
const autofill::PasswordForm* form_;
views::ImageView* image_view_;

Powered by Google App Engine
This is Rietveld 408576698