Use computeConstantValue instead of constantValue

Use computeConstantValue instead of constantValue

Paul, you recommended that we switch to this a while back, but it got
lost in the shuffle.  I noticed we seem to drop some unneeded null
checks in generated code with this change.  :-)

R=paulberry@google.com

Committed: https://github.com/dart-lang/sdk/commit/30c8ca6616a30c6c098c970e345a994cdd66691e

[vsm, 2017-02-09 19:26:45]

Description was changed from

==========
Use computeConstantValue instead of constantValue

Paul, you recommended that we switch to this a while back, but it got
lost in the shuffle.  I noticed we seem to drop some unneeded null
checks in generated code with this change.  :-)
==========

to

==========
Use computeConstantValue instead of constantValue

Paul, you recommended that we switch to this a while back, but it got
lost in the shuffle.  I noticed we seem to drop some unneeded null
checks in generated code with this change.  :-)
==========

[vsm, 2017-02-09 19:26:45]

vsm@google.com changed reviewers:
+ paulberry@google.com

[Paul Berry, 2017-02-09 20:34:02]

lgtm

[vsm, 2017-02-09 20:35:35]

Description was changed from

==========
Use computeConstantValue instead of constantValue

Paul, you recommended that we switch to this a while back, but it got
lost in the shuffle.  I noticed we seem to drop some unneeded null
checks in generated code with this change.  :-)
==========

to

==========
Use computeConstantValue instead of constantValue

Paul, you recommended that we switch to this a while back, but it got
lost in the shuffle.  I noticed we seem to drop some unneeded null
checks in generated code with this change.  :-)

R=paulberry@google.com

Committed:
https://github.com/dart-lang/sdk/commit/30c8ca6616a30c6c098c970e345a994cdd66691e
==========

[vsm, 2017-02-09 20:35:37]

Committed patchset #1 (id:1) manually as
30c8ca6616a30c6c098c970e345a994cdd66691e (presubmit successful).