Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7283)

Unified Diff: chrome/browser/resources/vr_shell/vr_shell_ui.js

Issue 2684233003: Switch tabs from VR shell. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/vr_shell/vr_shell_ui.js
diff --git a/chrome/browser/resources/vr_shell/vr_shell_ui.js b/chrome/browser/resources/vr_shell/vr_shell_ui.js
index cd8d7112bfbdcf51e742815d5819508fa1590855..b78bcd18a39e5128e8f1c100a3ea802e6cb8265f 100644
--- a/chrome/browser/resources/vr_shell/vr_shell_ui.js
+++ b/chrome/browser/resources/vr_shell/vr_shell_ui.js
@@ -690,7 +690,6 @@ var vrShellUi = (function() {
/** @const */ var TAB_CONTAINER_Y_OFFSET = 0.4;
/** @const */ var TAB_CONTAINER_Z_OFFSET = -1;
- this.tabs = {};
this.domTabs = {};
this.contentQuadId = contentQuadId;
this.domTabTemplate = document.querySelector(DOM_TAB_TEMPLATE_SELECTOR);
@@ -722,15 +721,19 @@ var vrShellUi = (function() {
// view.
let domTab = this.domTabTemplate.cloneNode(true);
domTab.removeAttribute('id');
+ domTab.addEventListener('click', function() {
+ api.doAction(api.Action.SHOW_TAB, {'id': domTab.tab.id});
+ });
this.domTabClip.appendChild(domTab);
this.domTabs[this.getQualifiedTabId(tab)] = domTab;
+ domTab.tab = tab;
return domTab;
}
resizeClipElement() {
// Resize clip element so that scrolling works.
this.domTabClip.style.width =
- (Object.keys(this.tabs).length * this.domTabWidth) + 'px';
+ (Object.keys(this.domTabs).length * this.domTabWidth) + 'px';
}
setTabs(tabs) {
@@ -738,7 +741,6 @@ var vrShellUi = (function() {
while (this.domTabClip.firstChild) {
this.domTabClip.removeChild(this.domTabClip.firstChild);
}
- this.tabs = {};
// Add new tabs.
for (let i = 0; i < tabs.length; i++) {
@@ -747,11 +749,10 @@ var vrShellUi = (function() {
}
hasTab(tab) {
- return this.getQualifiedTabId(tab) in this.tabs;
+ return this.getQualifiedTabId(tab) in this.domTabs;
}
addTab(tab) {
- this.tabs[this.getQualifiedTabId(tab)] = tab;
this.makeDomTab(tab);
this.updateTab(tab);
this.resizeClipElement();
@@ -771,7 +772,6 @@ var vrShellUi = (function() {
let domTab = this.domTabs[qualifiedTabId];
delete this.domTabs[qualifiedTabId];
this.domTabClip.removeChild(domTab);
- delete this.tabs[qualifiedTabId];
this.resizeClipElement();
}

Powered by Google App Engine
This is Rietveld 408576698