Switch tabs from VR shell.

chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.vr_shell;
 
 import android.app.Activity;
 import android.app.PendingIntent;
 import android.content.ComponentName;
 import android.content.Context;
@@ skipping 17 matching lines @@
 import org.chromium.base.Log;
 import org.chromium.base.VisibleForTesting;
 import org.chromium.base.annotations.CalledByNative;
 import org.chromium.base.annotations.JNINamespace;
 import org.chromium.base.library_loader.LibraryLoader;
 import org.chromium.chrome.browser.ChromeActivity;
 import org.chromium.chrome.browser.ChromeFeatureList;
 import org.chromium.chrome.browser.ChromeTabbedActivity;
 import org.chromium.chrome.browser.multiwindow.MultiWindowUtils;
 import org.chromium.chrome.browser.tab.Tab;
+import org.chromium.chrome.browser.tabmodel.TabModel;
+import org.chromium.chrome.browser.tabmodel.TabModelUtils;
 
 import java.lang.annotation.Retention;
 import java.lang.annotation.RetentionPolicy;
 import java.lang.reflect.Constructor;
 import java.lang.reflect.InvocationTargetException;
 
 /**
  * Manages interactions with the VR Shell.
  */
 @JNINamespace("vr_shell")
@@ skipping 572 matching lines @@
     }
 
     /**
      * @return Pointer to the native VrShellDelegate object.
      */
     @CalledByNative
     private long getNativePointer() {
         return mNativeVrShellDelegate;
     }
 
+    @CalledByNative
+    private void showTab(int id) {
+        Tab tab = mActivity.getTabModelSelector().getTabById(id);
+        if (tab != null) {

[cjgrant, 2017/02/10 16:02:15]

Should this be an early return instead?

[tiborg, 2017/02/10 16:34:17]

You mean instead of the nested if statements?

[cjgrant, 2017/02/10 18:14:29]

Yes.  That's the preference, to avoid excessive indentation, and make sure that
the typical execution path is clear.

[tiborg, 2017/02/13 17:35:37]

Done.

+            int index = mActivity.getTabModelSelector().getModel(tab.isIncognito()).indexOf(tab);

[tiborg, 2017/02/09 21:22:00]

I don't know why this line and the one below are so long. It's the result of
'git cl format'.

[mthiesse, 2017/02/09 21:37:56]

java lines are 100 characters long.

+
+            if (index != TabModel.INVALID_TAB_INDEX) {
+                TabModelUtils.setIndex(
+                        mActivity.getTabModelSelector().getModel(tab.isIncognito()), index);
+            }
+        }
+    }

[tiborg, 2017/02/09 21:22:00]

What would be the best way to deal with an unknown tab ID? Just ignore (like it
is right now), exception, or something else?

[mthiesse, 2017/02/09 21:37:56]

Yeah, ignoring it is probably best. 

+
     private native long nativeInit();
     private native void nativeSetPresentResult(long nativeVrShellDelegate, boolean result);
     private native void nativeDisplayActivate(long nativeVrShellDelegate);
     private native void nativeUpdateVSyncInterval(long nativeVrShellDelegate, long timebaseNanos,
             double intervalSeconds);
     private native void nativeOnPause(long nativeVrShellDelegate);
     private native void nativeOnResume(long nativeVrShellDelegate);
 }