chrome/browser/page_load_metrics/page_load_metrics_initialize.cc - Issue 2684153003: Add subresource filter page load metrics observer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/page_load_metrics_initialize.cc

Issue 2684153003: Add subresource filter page load metrics observer (Closed)

Patch Set: address comment Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/page_load_metrics/page_load_metrics_initialize.cc

diff --git a/chrome/browser/page_load_metrics/page_load_metrics_initialize.cc b/chrome/browser/page_load_metrics/page_load_metrics_initialize.cc

index 9eea0c7fe36eaafae45886b5bc53873e346c6a6d..a409b5eacb73f1a16cd1eed0c86dd8459272f852 100644

--- a/chrome/browser/page_load_metrics/page_load_metrics_initialize.cc

+++ b/chrome/browser/page_load_metrics/page_load_metrics_initialize.cc

@@ -25,6 +25,7 @@

#include "chrome/browser/page_load_metrics/observers/protocol_page_load_metrics_observer.h"

#include "chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer.h"

#include "chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer.h"

+#include "chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer.h"

#include "chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.h"

#include "chrome/browser/page_load_metrics/page_load_metrics_embedder_interface.h"

#include "chrome/browser/page_load_metrics/page_load_tracker.h"

@@ -81,6 +82,7 @@ void PageLoadMetricsEmbedder::RegisterObservers(

base::WrapUnique(new previews::PreviewsPageLoadMetricsObserver()));

tracker->AddObserver(

base::MakeUnique<ServiceWorkerPageLoadMetricsObserver>());

+ tracker->AddObserver(base::MakeUnique<SubresourceFilterMetricsObserver>());

tracker->AddObserver(

base::MakeUnique<HttpsEngagementPageLoadMetricsObserver>(

web_contents_->GetBrowserContext()));