Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(693)

Unified Diff: chrome/browser/page_load_metrics/page_load_tracker.cc

Issue 2684153003: Add subresource filter page load metrics observer (Closed)
Patch Set: address comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/page_load_tracker.cc
diff --git a/chrome/browser/page_load_metrics/page_load_tracker.cc b/chrome/browser/page_load_metrics/page_load_tracker.cc
index 6f161e9fa3d7913d4eba92157bb0c03939b0b0c4..9e0854b9b0a6dac2cb0e35742a7f997730afae0f 100644
--- a/chrome/browser/page_load_metrics/page_load_tracker.cc
+++ b/chrome/browser/page_load_metrics/page_load_tracker.cc
@@ -256,6 +256,8 @@ void DispatchObserverTimingCallbacks(PageLoadMetricsObserver* observer,
const PageLoadExtraInfo& extra_info) {
if (last_timing != new_timing)
observer->OnTimingUpdate(new_timing, extra_info);
+ if (extra_info.metadata.behavior_flags != last_metadata.behavior_flags)
Charlie Harrison 2017/02/09 19:19:13 Why not pull this above OnTimingUpdate too?
Bryan McQuade 2017/02/09 19:30:49 done
+ observer->OnLoadingBehaviorObserved(extra_info);
if (new_timing.dom_content_loaded_event_start &&
!last_timing.dom_content_loaded_event_start)
observer->OnDomContentLoadedEventStart(new_timing, extra_info);
@@ -277,8 +279,6 @@ void DispatchObserverTimingCallbacks(PageLoadMetricsObserver* observer,
observer->OnParseStart(new_timing, extra_info);
if (new_timing.parse_stop && !last_timing.parse_stop)
observer->OnParseStop(new_timing, extra_info);
- if (extra_info.metadata.behavior_flags != last_metadata.behavior_flags)
- observer->OnLoadingBehaviorObserved(extra_info);
}
} // namespace

Powered by Google App Engine
This is Rietveld 408576698