Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(915)

Unified Diff: content/browser/frame_host/navigator_impl.cc

Issue 2684143002: Remove deprecated navigation callbacks on WebContentsObserver that are now unused. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigator_impl.cc
diff --git a/content/browser/frame_host/navigator_impl.cc b/content/browser/frame_host/navigator_impl.cc
index 94204144d2e930e10952c2543e500bca6e9499af..2a87f4aad7b6e1413be1774ab6a574e013e39eaa 100644
--- a/content/browser/frame_host/navigator_impl.cc
+++ b/content/browser/frame_host/navigator_impl.cc
@@ -192,12 +192,6 @@ void NavigatorImpl::DidStartProvisionalLoad(
render_frame_host->navigation_handle());
}
- if (delegate_) {
- // Notify the observer about the start of the provisional load.
- delegate_->DidStartProvisionalLoad(render_frame_host, validated_url,
- is_error_page);
- }
-
if (is_error_page || IsBrowserSideNavigationEnabled())
return;
@@ -698,20 +692,6 @@ void NavigatorImpl::DidNavigate(
if (details.type != NAVIGATION_TYPE_NAV_IGNORE && delegate_) {
DCHECK_EQ(!render_frame_host->GetParent(),
did_navigate ? details.is_main_frame : false);
- ui::PageTransition transition_type = params.transition;
- // Whether or not a page transition was triggered by going backward or
- // forward in the history is only stored in the navigation controller's
- // entry list.
- if (did_navigate &&
- (controller_->GetLastCommittedEntry()->GetTransitionType() &
- ui::PAGE_TRANSITION_FORWARD_BACK)) {
- transition_type = ui::PageTransitionFromInt(
- params.transition | ui::PAGE_TRANSITION_FORWARD_BACK);
nasko 2017/02/10 19:44:58 Hmm, I wonder if we have a discrepancy between the
jam 2017/02/10 20:00:34 Given that no tests failed, I'm not inclined to ha
- }
-
- delegate_->DidCommitProvisionalLoad(render_frame_host,
- params.url,
- transition_type);
navigation_handle->DidCommitNavigation(params, details.did_replace_entry,
details.previous_url, details.type,
render_frame_host);

Powered by Google App Engine
This is Rietveld 408576698