content/browser/web_contents/web_contents_impl.h - Issue 2684143002: Remove deprecated navigation callbacks on WebContentsObserver that are now unused.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl.h

Issue 2684143002: Remove deprecated navigation callbacks on WebContentsObserver that are now unused. (Closed)

Patch Set: call old RFH's BrowserAccessibilityManager Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/web_contents/web_contents_impl.h

diff --git a/content/browser/web_contents/web_contents_impl.h b/content/browser/web_contents/web_contents_impl.h

index 72e4b50cdbd0727418fbd6913c29e6bbc2e57e2c..ae02d9a9815fdeed0f23c71441ad55bd85c9620b 100644

--- a/content/browser/web_contents/web_contents_impl.h

+++ b/content/browser/web_contents/web_contents_impl.h

@@ -571,22 +571,11 @@ class CONTENT_EXPORT WebContentsImpl

void DidRedirectNavigation(NavigationHandle* navigation_handle) override;

void ReadyToCommitNavigation(NavigationHandle* navigation_handle) override;

void DidFinishNavigation(NavigationHandle* navigation_handle) override;

- void DidStartProvisionalLoad(RenderFrameHostImpl* render_frame_host,

- const GURL& validated_url,

- bool is_error_page) override;

- void DidFailProvisionalLoadWithError(RenderFrameHostImpl* render_frame_host,

- const GURL& validated_url,

- int error_code,

- const base::string16& error_description,

- bool was_ignored_by_handler) override;

void DidFailLoadWithError(RenderFrameHostImpl* render_frame_host,

const GURL& url,

int error_code,

const base::string16& error_description,

bool was_ignored_by_handler) override;

- void DidCommitProvisionalLoad(RenderFrameHostImpl* render_frame_host,

- const GURL& url,

- ui::PageTransition transition_type) override;

void DidNavigateMainFramePreCommit(bool navigation_is_within_page) override;

void DidNavigateMainFramePostCommit(

RenderFrameHostImpl* render_frame_host,