Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Side by Side Diff: content/test/web_contents_observer_sanity_checker.cc

Issue 2684143002: Remove deprecated navigation callbacks on WebContentsObserver that are now unused. (Closed)
Patch Set: call old RFH's BrowserAccessibilityManager Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/test/web_contents_observer_sanity_checker.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/test/web_contents_observer_sanity_checker.h" 5 #include "content/test/web_contents_observer_sanity_checker.h"
6 6
7 #include "base/strings/stringprintf.h" 7 #include "base/strings/stringprintf.h"
8 #include "build/build_config.h" 8 #include "build/build_config.h"
9 #include "content/browser/frame_host/render_frame_host_impl.h" 9 #include "content/browser/frame_host/render_frame_host_impl.h"
10 #include "content/common/frame_messages.h" 10 #include "content/common/frame_messages.h"
(...skipping 191 matching lines...) Expand 10 before | Expand all | Expand 10 after
202 !navigation_handle->IsErrorPage()) || 202 !navigation_handle->IsErrorPage()) ||
203 navigation_handle->GetNetErrorCode() == net::OK); 203 navigation_handle->GetNetErrorCode() == net::OK);
204 CHECK_EQ(navigation_handle->GetWebContents(), web_contents()); 204 CHECK_EQ(navigation_handle->GetWebContents(), web_contents());
205 205
206 CHECK(!navigation_handle->HasCommitted() || 206 CHECK(!navigation_handle->HasCommitted() ||
207 navigation_handle->GetRenderFrameHost() != nullptr); 207 navigation_handle->GetRenderFrameHost() != nullptr);
208 208
209 ongoing_navigations_.erase(navigation_handle); 209 ongoing_navigations_.erase(navigation_handle);
210 } 210 }
211 211
212 void WebContentsObserverSanityChecker::DidStartProvisionalLoadForFrame(
213 RenderFrameHost* render_frame_host,
214 const GURL& validated_url,
215 bool is_error_page) {
216 AssertRenderFrameExists(render_frame_host);
217 }
218
219 void WebContentsObserverSanityChecker::DidCommitProvisionalLoadForFrame(
220 RenderFrameHost* render_frame_host,
221 const GURL& url,
222 ui::PageTransition transition_type) {
223 AssertRenderFrameExists(render_frame_host);
224 }
225
226 void WebContentsObserverSanityChecker::DidFailProvisionalLoad(
227 RenderFrameHost* render_frame_host,
228 const GURL& validated_url,
229 int error_code,
230 const base::string16& error_description,
231 bool was_ignored_by_handler) {
232 AssertRenderFrameExists(render_frame_host);
233 }
234
235 void WebContentsObserverSanityChecker::DidNavigateMainFrame(
236 const LoadCommittedDetails& details,
237 const FrameNavigateParams& params) {
238 AssertMainFrameExists();
239 }
240
241 void WebContentsObserverSanityChecker::DidNavigateAnyFrame(
242 RenderFrameHost* render_frame_host,
243 const LoadCommittedDetails& details,
244 const FrameNavigateParams& params) {
245 AssertRenderFrameExists(render_frame_host);
246 }
247
248 void WebContentsObserverSanityChecker::DocumentAvailableInMainFrame() { 212 void WebContentsObserverSanityChecker::DocumentAvailableInMainFrame() {
249 AssertMainFrameExists(); 213 AssertMainFrameExists();
250 } 214 }
251 215
252 void WebContentsObserverSanityChecker::DocumentOnLoadCompletedInMainFrame() { 216 void WebContentsObserverSanityChecker::DocumentOnLoadCompletedInMainFrame() {
253 AssertMainFrameExists(); 217 AssertMainFrameExists();
254 } 218 }
255 219
256 void WebContentsObserverSanityChecker::DocumentLoadedInFrame( 220 void WebContentsObserverSanityChecker::DocumentLoadedInFrame(
257 RenderFrameHost* render_frame_host) { 221 RenderFrameHost* render_frame_host) {
(...skipping 148 matching lines...) Expand 10 before | Expand all | Expand 10 after
406 if (live_routes_.count(entry.first)) 370 if (live_routes_.count(entry.first))
407 return true; 371 return true;
408 if (current_hosts_.count(entry.first)) 372 if (current_hosts_.count(entry.first))
409 return true; 373 return true;
410 } 374 }
411 } 375 }
412 return false; 376 return false;
413 } 377 }
414 378
415 } // namespace content 379 } // namespace content
OLDNEW
« no previous file with comments | « content/test/web_contents_observer_sanity_checker.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698