Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Side by Side Diff: content/browser/frame_host/navigator_delegate.h

Issue 2684143002: Remove deprecated navigation callbacks on WebContentsObserver that are now unused. (Closed)
Patch Set: call old RFH's BrowserAccessibilityManager Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | content/browser/frame_host/navigator_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_DELEGATE_H_ 5 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_DELEGATE_H_
6 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_DELEGATE_H_ 6 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_DELEGATE_H_
7 7
8 #include "base/strings/string16.h" 8 #include "base/strings/string16.h"
9 #include "content/public/browser/invalidate_type.h" 9 #include "content/public/browser/invalidate_type.h"
10 #include "content/public/browser/navigation_controller.h" 10 #include "content/public/browser/navigation_controller.h"
(...skipping 29 matching lines...) Expand all
40 virtual void ReadyToCommitNavigation(NavigationHandle* navigation_handle) {} 40 virtual void ReadyToCommitNavigation(NavigationHandle* navigation_handle) {}
41 41
42 // Called when the navigation finished: it was either committed or canceled 42 // Called when the navigation finished: it was either committed or canceled
43 // before commit. Note that |navigation_handle| will be destroyed at the end 43 // before commit. Note that |navigation_handle| will be destroyed at the end
44 // of this call. 44 // of this call.
45 virtual void DidFinishNavigation(NavigationHandle* navigation_handle) {} 45 virtual void DidFinishNavigation(NavigationHandle* navigation_handle) {}
46 46
47 // TODO(clamy): all methods below that are related to navigation 47 // TODO(clamy): all methods below that are related to navigation
48 // events should go away in favor of the ones above. 48 // events should go away in favor of the ones above.
49 49
50 // The RenderFrameHost started a provisional load for the frame
51 // represented by |render_frame_host|.
52 virtual void DidStartProvisionalLoad(RenderFrameHostImpl* render_frame_host,
53 const GURL& validated_url,
54 bool is_error_page) {}
55
56 // A provisional load in |render_frame_host| failed. 50 // A provisional load in |render_frame_host| failed.
57 virtual void DidFailProvisionalLoadWithError( 51 virtual void DidFailProvisionalLoadWithError(
58 RenderFrameHostImpl* render_frame_host, 52 RenderFrameHostImpl* render_frame_host,
59 const GURL& validated_url, 53 const GURL& validated_url,
60 int error_code, 54 int error_code,
61 const base::string16& error_description, 55 const base::string16& error_description,
62 bool was_ignored_by_handler) {} 56 bool was_ignored_by_handler) {}
63 57
64 // Document load in |render_frame_host| failed. 58 // Document load in |render_frame_host| failed.
65 virtual void DidFailLoadWithError( 59 virtual void DidFailLoadWithError(
66 RenderFrameHostImpl* render_frame_host, 60 RenderFrameHostImpl* render_frame_host,
67 const GURL& url, 61 const GURL& url,
68 int error_code, 62 int error_code,
69 const base::string16& error_description, 63 const base::string16& error_description,
70 bool was_ignored_by_handler) {} 64 bool was_ignored_by_handler) {}
71 65
72 // A navigation was committed in |render_frame_host|.
73 virtual void DidCommitProvisionalLoad(
74 RenderFrameHostImpl* render_frame_host,
75 const GURL& url,
76 ui::PageTransition transition_type) {}
77
78 // Handles post-navigation tasks in navigation BEFORE the entry has been 66 // Handles post-navigation tasks in navigation BEFORE the entry has been
79 // committed to the NavigationController. 67 // committed to the NavigationController.
80 virtual void DidNavigateMainFramePreCommit(bool navigation_is_within_page) {} 68 virtual void DidNavigateMainFramePreCommit(bool navigation_is_within_page) {}
81 69
82 // Handles post-navigation tasks in navigation AFTER the entry has been 70 // Handles post-navigation tasks in navigation AFTER the entry has been
83 // committed to the NavigationController. Note that the NavigationEntry is 71 // committed to the NavigationController. Note that the NavigationEntry is
84 // not provided since it may be invalid/changed after being committed. The 72 // not provided since it may be invalid/changed after being committed. The
85 // NavigationController's last committed entry is for this navigation. 73 // NavigationController's last committed entry is for this navigation.
86 virtual void DidNavigateMainFramePostCommit( 74 virtual void DidNavigateMainFramePostCommit(
87 RenderFrameHostImpl* render_frame_host, 75 RenderFrameHostImpl* render_frame_host,
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
143 // wants to see passed to the corresponding URLRequest on the IO thread. 131 // wants to see passed to the corresponding URLRequest on the IO thread.
144 // In the case of a navigation to an interstitial, no call will be made to the 132 // In the case of a navigation to an interstitial, no call will be made to the
145 // embedder and |nullptr| is returned. 133 // embedder and |nullptr| is returned.
146 virtual std::unique_ptr<NavigationUIData> GetNavigationUIData( 134 virtual std::unique_ptr<NavigationUIData> GetNavigationUIData(
147 NavigationHandle* navigation_handle); 135 NavigationHandle* navigation_handle);
148 }; 136 };
149 137
150 } // namspace content 138 } // namspace content
151 139
152 #endif // CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_DELEGATE_H_ 140 #endif // CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_DELEGATE_H_
OLDNEW
« no previous file with comments | « no previous file | content/browser/frame_host/navigator_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698