Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3220)

Unified Diff: chrome/browser/ui/webui/sync_file_system_internals/file_metadata_handler.cc

Issue 268413002: [SyncFS] Make DumpFiles async (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: work for a nit Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/sync_file_system_internals/file_metadata_handler.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/sync_file_system_internals/file_metadata_handler.cc
diff --git a/chrome/browser/ui/webui/sync_file_system_internals/file_metadata_handler.cc b/chrome/browser/ui/webui/sync_file_system_internals/file_metadata_handler.cc
index 094f9d72ab0facc24bb8e9ef34271b25318c4756..c40b39c53ac849f5699e598dc01fd7c1def5a6c7 100644
--- a/chrome/browser/ui/webui/sync_file_system_internals/file_metadata_handler.cc
+++ b/chrome/browser/ui/webui/sync_file_system_internals/file_metadata_handler.cc
@@ -72,9 +72,10 @@ void FileMetadataHandler::GetExtensions(const base::ListValue* args) {
web_ui()->CallJavascriptFunction("FileMetadata.onGetExtensions", list);
}
-void FileMetadataHandler::DidGetFileMetadata(const base::ListValue* files) {
- DCHECK(files);
- web_ui()->CallJavascriptFunction("FileMetadata.onGetFileMetadata", *files);
+void FileMetadataHandler::DidGetFileMetadata(
+ const base::ListValue& files) {
+ web_ui()->CallJavascriptFunction("FileMetadata.onGetFileMetadata",
+ files);
nhiroki 2014/05/13 03:26:20 nit: probably you don't have to add this line brea
peria 2014/05/13 03:51:29 Done.
}
} // namespace syncfs_internals
« no previous file with comments | « chrome/browser/ui/webui/sync_file_system_internals/file_metadata_handler.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698