Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Issue 2684113002: [ON HOLD] Deallocate read buffer in MDnsClientImpl::SocketHandler if done reading (Closed)

Created:
3 years, 10 months ago by xunjieli
Modified:
3 years, 10 months ago
Reviewers:
Julia Tuttle
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ON HOLD]Deallocate read buffer in MDnsClientImpl::SocketHandler if done reading When SocketHandler is done reading, free its DnsResponse which owns the 9KB read buffer. The DnsResponse is never used again, but SocketHandler can be kept around in MDnsConnection::|socket_handlers_| for a while. This CL additionally renames DoLoop() to DoRead(). BUG=690095

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -13 lines) Patch
M net/dns/mdns_client_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/dns/mdns_client_impl.cc View 2 chunks +14 lines, -11 lines 0 comments Download

Messages

Total messages: 12 (10 generated)
xunjieli
Julia, PTAL. Thanks!
3 years, 10 months ago (2017-02-08 20:24:35 UTC) #8
xunjieli
3 years, 10 months ago (2017-02-08 21:27:00 UTC) #11
On 2017/02/08 20:24:35, xunjieli wrote:
> Julia, PTAL. Thanks!

Hmm.. Sorry, this actually doesn't address the issue. Looks like the the socket
handlers are waiting for read result. They haven't done reading. I will think
more about it.

Powered by Google App Engine
This is Rietveld 408576698