Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Unified Diff: media/video/gpu_memory_buffer_video_frame_pool.h

Issue 2684103005: Allow media track switching. (Closed)
Patch Set: Fixed comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/video/gpu_memory_buffer_video_frame_pool.h
diff --git a/media/video/gpu_memory_buffer_video_frame_pool.h b/media/video/gpu_memory_buffer_video_frame_pool.h
index ed4b3617e53cd39b0cf78d7f7dd7e6b9d16ddd47..b7c16b5a1aa8affcf552641191c90897c3ca5b07 100644
--- a/media/video/gpu_memory_buffer_video_frame_pool.h
+++ b/media/video/gpu_memory_buffer_video_frame_pool.h
@@ -24,6 +24,11 @@ class GpuVideoAcceleratorFactories;
// The pool recycles resources to a void unnecessarily allocating and
// destroying textures, images and GpuMemoryBuffer that could result
// in a round trip to the browser/GPU process.
+// NOTE: Destroying the pool will not immediately invalidate outstanding video
+// frames. GPU memory buffers will be kept alive by video frames indirectly
+// referencing them. Video frames themselves are ref-counted and will be
+// released when they are no longer needed, potentially after the pool is
+// destroyed.
class MEDIA_EXPORT GpuMemoryBufferVideoFramePool {
public:
GpuMemoryBufferVideoFramePool();
« no previous file with comments | « media/test/pipeline_integration_test_base.cc ('k') | third_party/WebKit/LayoutTests/media/avtrack/track-switching.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698