Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(654)

Unified Diff: media/video/gpu_memory_buffer_video_frame_pool.h

Issue 2684103005: Allow media track switching. (Closed)
Patch Set: rebase / resolve conflict Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/video/gpu_memory_buffer_video_frame_pool.h
diff --git a/media/video/gpu_memory_buffer_video_frame_pool.h b/media/video/gpu_memory_buffer_video_frame_pool.h
index ed4b3617e53cd39b0cf78d7f7dd7e6b9d16ddd47..cf4ce3bf0e04b29b254c1e7504a4af6fedf22abc 100644
--- a/media/video/gpu_memory_buffer_video_frame_pool.h
+++ b/media/video/gpu_memory_buffer_video_frame_pool.h
@@ -24,6 +24,9 @@ class GpuVideoAcceleratorFactories;
// The pool recycles resources to a void unnecessarily allocating and
// destroying textures, images and GpuMemoryBuffer that could result
// in a round trip to the browser/GPU process.
+// NOTE: Destroying the pool will not immediately invalidate outstanding video
+// frames. GPU memory buffers are ref-counted and will be kept alive for as long
Daniele Castagna 2017/03/31 00:58:13 nit: Actually VideoFrames are ref-counted. The res
servolk 2017/03/31 01:04:19 Thanks for correcting me. How about this? // NOTE:
Daniele Castagna 2017/03/31 01:20:54 Thanks to you for adding this note. The comment s
servolk 2017/03/31 01:23:21 Done.
+// as the corresponding video frame is alive.
class MEDIA_EXPORT GpuMemoryBufferVideoFramePool {
public:
GpuMemoryBufferVideoFramePool();
« no previous file with comments | « media/test/pipeline_integration_test_base.cc ('k') | third_party/WebKit/LayoutTests/media/avtrack/track-switching.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698