Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Side by Side Diff: src/arm/macro-assembler-arm.h

Issue 26841009: Make TestJSArrayForAllocationMemento less awkward. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Comments addressed. Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/lithium-codegen-arm.cc ('k') | src/arm/macro-assembler-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1370 matching lines...) Expand 10 before | Expand all | Expand 10 after
1381 1381
1382 // Expects object in r0 and returns map with validated enum cache 1382 // Expects object in r0 and returns map with validated enum cache
1383 // in r0. Assumes that any other register can be used as a scratch. 1383 // in r0. Assumes that any other register can be used as a scratch.
1384 void CheckEnumCache(Register null_value, Label* call_runtime); 1384 void CheckEnumCache(Register null_value, Label* call_runtime);
1385 1385
1386 // AllocationMemento support. Arrays may have an associated 1386 // AllocationMemento support. Arrays may have an associated
1387 // AllocationMemento object that can be checked for in order to pretransition 1387 // AllocationMemento object that can be checked for in order to pretransition
1388 // to another type. 1388 // to another type.
1389 // On entry, receiver_reg should point to the array object. 1389 // On entry, receiver_reg should point to the array object.
1390 // scratch_reg gets clobbered. 1390 // scratch_reg gets clobbered.
1391 // If allocation info is present, condition flags are set to eq 1391 // If allocation info is present, condition flags are set to eq.
1392 void TestJSArrayForAllocationMemento(Register receiver_reg, 1392 void TestJSArrayForAllocationMemento(Register receiver_reg,
1393 Register scratch_reg); 1393 Register scratch_reg,
1394 Label* no_memento_found);
1395
1396 void JumpIfJSArrayHasAllocationMemento(Register receiver_reg,
1397 Register scratch_reg,
1398 Label* memento_found) {
1399 Label no_memento_found;
1400 TestJSArrayForAllocationMemento(receiver_reg, scratch_reg,
1401 &no_memento_found);
1402 b(eq, memento_found);
1403 bind(&no_memento_found);
1404 }
1394 1405
1395 private: 1406 private:
1396 void CallCFunctionHelper(Register function, 1407 void CallCFunctionHelper(Register function,
1397 int num_reg_arguments, 1408 int num_reg_arguments,
1398 int num_double_arguments); 1409 int num_double_arguments);
1399 1410
1400 void Jump(intptr_t target, RelocInfo::Mode rmode, Condition cond = al); 1411 void Jump(intptr_t target, RelocInfo::Mode rmode, Condition cond = al);
1401 1412
1402 // Helper functions for generating invokes. 1413 // Helper functions for generating invokes.
1403 void InvokePrologue(const ParameterCount& expected, 1414 void InvokePrologue(const ParameterCount& expected,
(...skipping 103 matching lines...) Expand 10 before | Expand all | Expand 10 after
1507 #define __FILE_LINE__ __FILE__ ":" CODE_COVERAGE_TOSTRING(__LINE__) 1518 #define __FILE_LINE__ __FILE__ ":" CODE_COVERAGE_TOSTRING(__LINE__)
1508 #define ACCESS_MASM(masm) masm->stop(__FILE_LINE__); masm-> 1519 #define ACCESS_MASM(masm) masm->stop(__FILE_LINE__); masm->
1509 #else 1520 #else
1510 #define ACCESS_MASM(masm) masm-> 1521 #define ACCESS_MASM(masm) masm->
1511 #endif 1522 #endif
1512 1523
1513 1524
1514 } } // namespace v8::internal 1525 } } // namespace v8::internal
1515 1526
1516 #endif // V8_ARM_MACRO_ASSEMBLER_ARM_H_ 1527 #endif // V8_ARM_MACRO_ASSEMBLER_ARM_H_
OLDNEW
« no previous file with comments | « src/arm/lithium-codegen-arm.cc ('k') | src/arm/macro-assembler-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698