Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Unified Diff: chrome/browser/ui/javascript_dialogs/javascript_dialog.cc

Issue 2684093002: Rename JavaScript "messages" to "dialogs". (Closed)
Patch Set: win fox Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/javascript_dialogs/javascript_dialog.cc
diff --git a/chrome/browser/ui/javascript_dialogs/javascript_dialog.cc b/chrome/browser/ui/javascript_dialogs/javascript_dialog.cc
index 12ea34a784a96792a936aaf365dc40f3cd7fe15f..4151a8265b932c5baf75fe0b20606e26cf3185ff 100644
--- a/chrome/browser/ui/javascript_dialogs/javascript_dialog.cc
+++ b/chrome/browser/ui/javascript_dialogs/javascript_dialog.cc
@@ -20,12 +20,12 @@ base::WeakPtr<JavaScriptDialog> JavaScriptDialog::Create(
content::WebContents* parent_web_contents,
content::WebContents* alerting_web_contents,
const base::string16& title,
- content::JavaScriptMessageType message_type,
+ content::JavaScriptDialogType dialog_type,
const base::string16& message_text,
const base::string16& default_prompt_text,
const content::JavaScriptDialogManager::DialogClosedCallback&
dialog_callback) {
return JavaScriptDialogViews::Create(
- parent_web_contents, alerting_web_contents, title, message_type,
+ parent_web_contents, alerting_web_contents, title, dialog_type,
message_text, default_prompt_text, dialog_callback);
}

Powered by Google App Engine
This is Rietveld 408576698