Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10103)

Unified Diff: chrome/browser/ui/cocoa/javascript_app_modal_dialog_cocoa.mm

Issue 2684093002: Rename JavaScript "messages" to "dialogs". (Closed)
Patch Set: win fox Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/javascript_app_modal_dialog_cocoa.mm
diff --git a/chrome/browser/ui/cocoa/javascript_app_modal_dialog_cocoa.mm b/chrome/browser/ui/cocoa/javascript_app_modal_dialog_cocoa.mm
index 1b84a9769128f614f23e8f551e0293e330957730..0e56c9802ce1a2083f7acdefee7e05e62419096a 100644
--- a/chrome/browser/ui/cocoa/javascript_app_modal_dialog_cocoa.mm
+++ b/chrome/browser/ui/cocoa/javascript_app_modal_dialog_cocoa.mm
@@ -238,11 +238,11 @@ JavaScriptAppModalDialogCocoa::JavaScriptAppModalDialogCocoa(
NSString* other_button = l10n_util::GetNSStringWithFixup(IDS_APP_CANCEL);
bool text_field = false;
bool one_button = false;
- switch (dialog_->javascript_message_type()) {
- case content::JAVASCRIPT_MESSAGE_TYPE_ALERT:
+ switch (dialog_->javascript_dialog_type()) {
+ case content::JAVASCRIPT_DIALOG_TYPE_ALERT:
one_button = true;
break;
- case content::JAVASCRIPT_MESSAGE_TYPE_CONFIRM:
+ case content::JAVASCRIPT_DIALOG_TYPE_CONFIRM:
if (dialog_->is_before_unload_dialog()) {
if (dialog_->is_reload()) {
default_button = l10n_util::GetNSStringWithFixup(
@@ -257,7 +257,7 @@ JavaScriptAppModalDialogCocoa::JavaScriptAppModalDialogCocoa(
}
}
break;
- case content::JAVASCRIPT_MESSAGE_TYPE_PROMPT:
+ case content::JAVASCRIPT_DIALOG_TYPE_PROMPT:
text_field = true;
break;

Powered by Google App Engine
This is Rietveld 408576698