Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1470)

Unified Diff: android_webview/browser/aw_contents_client_bridge_base.h

Issue 2684093002: Rename JavaScript "messages" to "dialogs". (Closed)
Patch Set: win fox Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | android_webview/browser/aw_javascript_dialog_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/browser/aw_contents_client_bridge_base.h
diff --git a/android_webview/browser/aw_contents_client_bridge_base.h b/android_webview/browser/aw_contents_client_bridge_base.h
index 3a60dbca2f4effa2751a8147d6a51d0a5c39e5f4..6eeef825e6931eb857cdc006e51b3f7ef7f05f0a 100644
--- a/android_webview/browser/aw_contents_client_bridge_base.h
+++ b/android_webview/browser/aw_contents_client_bridge_base.h
@@ -60,12 +60,12 @@ class AwContentsClientBridgeBase {
std::unique_ptr<content::ClientCertificateDelegate> delegate) = 0;
virtual void RunJavaScriptDialog(
- content::JavaScriptMessageType message_type,
+ content::JavaScriptDialogType dialog_type,
const GURL& origin_url,
const base::string16& message_text,
const base::string16& default_prompt_text,
- const content::JavaScriptDialogManager::DialogClosedCallback& callback)
- = 0;
+ const content::JavaScriptDialogManager::DialogClosedCallback&
+ callback) = 0;
virtual void RunBeforeUnloadDialog(
const GURL& origin_url,
« no previous file with comments | « no previous file | android_webview/browser/aw_javascript_dialog_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698