Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Unified Diff: ios/chrome/browser/upgrade/upgrade_center_unittest.mm

Issue 2684073007: [ObjC ARC] Converts ios/chrome/browser/upgrade:unit_tests to ARC. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/upgrade/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/upgrade/upgrade_center_unittest.mm
diff --git a/ios/chrome/browser/upgrade/upgrade_center_unittest.mm b/ios/chrome/browser/upgrade/upgrade_center_unittest.mm
index b8b1b1ebe3ab944595a510b7502c64bbf229c105..d4bb58cccb7ea192f3f3eb50f72a1899e511bca8 100644
--- a/ios/chrome/browser/upgrade/upgrade_center_unittest.mm
+++ b/ios/chrome/browser/upgrade/upgrade_center_unittest.mm
@@ -4,10 +4,13 @@
#import "ios/chrome/browser/upgrade/upgrade_center.h"
-#include "base/mac/scoped_nsobject.h"
#include "ios/chrome/browser/upgrade/upgrade_recommended_details.h"
#include "testing/platform_test.h"
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "This file requires ARC support."
+#endif
+
namespace {
class UpgradeCenterTest : public PlatformTest {
@@ -51,8 +54,8 @@ namespace {
TEST_F(UpgradeCenterTest, NoUpgrade) {
EXPECT_EQ(count_, 0u);
- base::scoped_nsobject<FakeUpgradeCenterClient> fake(
- [[FakeUpgradeCenterClient alloc] initWithTest:this]);
+ FakeUpgradeCenterClient* fake =
+ [[FakeUpgradeCenterClient alloc] initWithTest:this];
[[UpgradeCenter sharedInstance] registerClient:fake];
EXPECT_EQ(count_, 0u);
[[UpgradeCenter sharedInstance] unregisterClient:fake];
@@ -60,8 +63,8 @@ TEST_F(UpgradeCenterTest, NoUpgrade) {
TEST_F(UpgradeCenterTest, GoodUpgradeAfterRegistration) {
EXPECT_EQ(count_, 0u);
- base::scoped_nsobject<FakeUpgradeCenterClient> fake(
- [[FakeUpgradeCenterClient alloc] initWithTest:this]);
+ FakeUpgradeCenterClient* fake =
+ [[FakeUpgradeCenterClient alloc] initWithTest:this];
[[UpgradeCenter sharedInstance] registerClient:fake];
EXPECT_EQ(count_, 0u);
@@ -79,16 +82,16 @@ TEST_F(UpgradeCenterTest, GoodUpgradeBeforeRegistration) {
details.upgrade_url = GURL("http://foobar.org");
[[UpgradeCenter sharedInstance] upgradeNotificationDidOccur:details];
EXPECT_EQ(count_, 0u);
- base::scoped_nsobject<FakeUpgradeCenterClient> fake(
- [[FakeUpgradeCenterClient alloc] initWithTest:this]);
+ FakeUpgradeCenterClient* fake =
+ [[FakeUpgradeCenterClient alloc] initWithTest:this];
[[UpgradeCenter sharedInstance] registerClient:fake];
EXPECT_EQ(count_, 1u);
[[UpgradeCenter sharedInstance] unregisterClient:fake];
};
TEST_F(UpgradeCenterTest, NoRepeatedDisplay) {
- base::scoped_nsobject<FakeUpgradeCenterClient> fake(
- [[FakeUpgradeCenterClient alloc] initWithTest:this]);
+ FakeUpgradeCenterClient* fake =
+ [[FakeUpgradeCenterClient alloc] initWithTest:this];
[[UpgradeCenter sharedInstance] registerClient:fake];
EXPECT_EQ(count_, 0u);
@@ -112,8 +115,8 @@ TEST_F(UpgradeCenterTest, NoRepeatedDisplay) {
};
TEST_F(UpgradeCenterTest, NewVersionResetsInterval) {
- base::scoped_nsobject<FakeUpgradeCenterClient> fake(
- [[FakeUpgradeCenterClient alloc] initWithTest:this]);
+ FakeUpgradeCenterClient* fake =
+ [[FakeUpgradeCenterClient alloc] initWithTest:this];
[[UpgradeCenter sharedInstance] registerClient:fake];
EXPECT_EQ(count_, 0u);
« no previous file with comments | « ios/chrome/browser/upgrade/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698