Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Unified Diff: cc/resources/video_resource_updater.cc

Issue 2684073006: cc: UYVY video is not premultiplied rgba
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | cc/resources/video_resource_updater_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/resources/video_resource_updater.cc
diff --git a/cc/resources/video_resource_updater.cc b/cc/resources/video_resource_updater.cc
index 6c08a31b9c4fa584c3cea2533a038a0f3d5eaec3..cc5249b03c9a176e3129d9dc5dbd0580f8962258 100644
--- a/cc/resources/video_resource_updater.cc
+++ b/cc/resources/video_resource_updater.cc
@@ -40,7 +40,7 @@ VideoFrameExternalResources::ResourceType ResourceTypeForVideoFrame(
case media::PIXEL_FORMAT_UYVY:
switch (video_frame->mailbox_holder(0).texture_target) {
case GL_TEXTURE_2D:
Daniele Castagna 2017/02/28 03:17:53 Isn't CrOS using TEXTURE_EXTERNAL_OES?
dshwang 2017/02/28 04:18:44 Not always TEXTURE_EXTERNAL_OES GPU video decoder
- return (video_frame->format() == media::PIXEL_FORMAT_XRGB)
+ return (video_frame->format() != media::PIXEL_FORMAT_ARGB)
? VideoFrameExternalResources::RGB_RESOURCE
: VideoFrameExternalResources::RGBA_PREMULTIPLIED_RESOURCE;
case GL_TEXTURE_EXTERNAL_OES:
« no previous file with comments | « no previous file | cc/resources/video_resource_updater_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698