cc: UYVY video is not premultiplied rgba

cc/resources/video_resource_updater.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/resources/video_resource_updater.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <algorithm>
@@ skipping 21 matching lines @@
 
 const ResourceFormat kRGBResourceFormat = RGBA_8888;
 
 VideoFrameExternalResources::ResourceType ResourceTypeForVideoFrame(
     media::VideoFrame* video_frame) {
   switch (video_frame->format()) {
     case media::PIXEL_FORMAT_ARGB:
     case media::PIXEL_FORMAT_XRGB:
     case media::PIXEL_FORMAT_UYVY:
       switch (video_frame->mailbox_holder(0).texture_target) {
         case GL_TEXTURE_2D:

[Daniele Castagna, 2017/02/28 03:17:53]

Isn't CrOS using TEXTURE_EXTERNAL_OES?

[dshwang, 2017/02/28 04:18:44]

Not always TEXTURE_EXTERNAL_OES

GPU video decoder uses TEXTURE_EXTERNAL_OES
GpuMemoryBufferVideoFramePool with native GMB uses TEXTURE_EXTERNAL_OES
GpuMemoryBufferVideoFramePool with software-fallback GMB uses GL_TEXTURE_2D

-          return (video_frame->format() == media::PIXEL_FORMAT_XRGB)
+          return (video_frame->format() != media::PIXEL_FORMAT_ARGB)
                      ? VideoFrameExternalResources::RGB_RESOURCE
                      : VideoFrameExternalResources::RGBA_PREMULTIPLIED_RESOURCE;
         case GL_TEXTURE_EXTERNAL_OES:
           return video_frame->metadata()->IsTrue(
                      media::VideoFrameMetadata::COPY_REQUIRED)
                      ? VideoFrameExternalResources::RGBA_RESOURCE
                      : VideoFrameExternalResources::STREAM_TEXTURE_RESOURCE;
         case GL_TEXTURE_RECTANGLE_ARB:
           return VideoFrameExternalResources::RGB_RESOURCE;
         default:
@@ skipping 761 matching lines @@
   if (lost_resource) {
     resource_it->clear_refs();
     updater->DeleteResource(resource_it);
     return;
   }
 
   resource_it->remove_ref();
 }
 
 }  // namespace cc