Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 2684073005: VM: Make debug printing of AST/scopes use --print-flow-graph-filter flag. (Closed)

Created:
3 years, 10 months ago by Florian Schneider
Modified:
3 years, 10 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

VM: Make debug printing of AST/scopes use --print-flow-graph-filter flag. Helps reading debug output from these flags. R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/504e6bb1dc9a94aeeeebba9dfe342e0523523239

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M runtime/vm/flow_graph_builder.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Florian Schneider
3 years, 10 months ago (2017-02-09 00:23:39 UTC) #2
rmacnak
lgtm
3 years, 10 months ago (2017-02-09 00:25:15 UTC) #3
Florian Schneider
3 years, 10 months ago (2017-02-09 00:26:45 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
504e6bb1dc9a94aeeeebba9dfe342e0523523239 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698