Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Unified Diff: ios/chrome/browser/tabs/tab_model.mm

Issue 2684073002: Extract TabModelObservers from tab_model.mm to its own file. (Closed)
Patch Set: Rebase and address comment. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/tabs/BUILD.gn ('k') | ios/chrome/browser/tabs/tab_model_observers.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/tabs/tab_model.mm
diff --git a/ios/chrome/browser/tabs/tab_model.mm b/ios/chrome/browser/tabs/tab_model.mm
index a49cd809de28efeae94513c1f000834b8444c66e..08fc2f599aa00c5298b1cff082345986ab461651 100644
--- a/ios/chrome/browser/tabs/tab_model.mm
+++ b/ios/chrome/browser/tabs/tab_model.mm
@@ -8,7 +8,6 @@
#include <vector>
#include "base/bind.h"
-#import "base/ios/crb_protocol_observers.h"
#include "base/logging.h"
#import "base/mac/scoped_nsobject.h"
#include "base/metrics/histogram_macros.h"
@@ -31,7 +30,7 @@
#include "ios/chrome/browser/tab_parenting_global_observer.h"
#import "ios/chrome/browser/tabs/tab.h"
#import "ios/chrome/browser/tabs/tab_model_list.h"
-#import "ios/chrome/browser/tabs/tab_model_observer.h"
+#import "ios/chrome/browser/tabs/tab_model_observers.h"
#import "ios/chrome/browser/tabs/tab_model_order_controller.h"
#import "ios/chrome/browser/tabs/tab_model_synced_window_delegate.h"
#import "ios/chrome/browser/xcallback_parameters.h"
@@ -109,11 +108,6 @@ void CleanCertificatePolicyCache(
} // anonymous namespace
-@interface TabModelObservers : CRBProtocolObservers<TabModelObserver>
-@end
-@implementation TabModelObservers
-@end
-
@interface TabModel ()<TabUsageRecorderDelegate> {
// Array of |Tab| objects.
base::scoped_nsobject<NSMutableArray> _tabs;
@@ -255,8 +249,7 @@ void CleanCertificatePolicyCache(
sessionService:(SessionServiceIOS*)service
browserState:(ios::ChromeBrowserState*)browserState {
if ((self = [super init])) {
- _observers.reset([[TabModelObservers
- observersWithProtocol:@protocol(TabModelObserver)] retain]);
+ _observers.reset([[TabModelObservers observers] retain]);
_browserState = browserState;
DCHECK(_browserState);
« no previous file with comments | « ios/chrome/browser/tabs/BUILD.gn ('k') | ios/chrome/browser/tabs/tab_model_observers.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698