ios/chrome/browser/tabs/tab_model_observers.mm - Issue 2684073002: Extract TabModelObservers from tab_model.mm to its own file.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/chrome/browser/tabs/tab_model_observers.mm

Issue 2684073002: Extract TabModelObservers from tab_model.mm to its own file. (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #import "ios/chrome/browser/tabs/tab_model_observers.h"

	6

	7 #if !defined(__has_feature) \|\| !__has_feature(objc_arc)

	8 #error "This file requires ARC support."

	9 #endif

	10

	11 @implementation TabModelObservers

	12

	13 + (instancetype)observers {
	rohitrao (ping after 24h) 2017/02/13 19:24:28 Was this not necessary in the original implementat Was this not necessary in the original implementation? Why have you added it now? sdefresne 2017/02/14 10:11:31 This is just a convenience method, not necessary b Show quoted text On 2017/02/13 19:24:28, rohitrao wrote: > Was this not necessary in the original implementation? Why have you added it > now? This is just a convenience method, not necessary but allow for shorter lines by replacing: TabModelObserver* observers = [TabModelObservers observersWithProtocol:@protocol(TabModelObserver)]; with: TabModelObserver* observers = [TabModelObservers observers];
	14 return [self observersWithProtocol:@protocol(TabModelObserver)];

	15 }

	16

	17 @end

OLD	NEW