Allow a ParseInfo without a script for %SetCode users

src/compiler/pipeline.cc

Index: src/compiler/pipeline.cc
diff --git a/src/compiler/pipeline.cc b/src/compiler/pipeline.cc
index 2de587e820ee3cd39cdec13604cc5883132cc837..d53ccc3078661e00757e6360a50595fdf62c49a9 100644
--- a/src/compiler/pipeline.cc
+++ b/src/compiler/pipeline.cc
@@ -545,13 +545,13 @@ PipelineStatistics* CreatePipelineStatistics(CompilationInfo* info,
 
 class PipelineCompilationJob final : public CompilationJob {
  public:
-  PipelineCompilationJob(Isolate* isolate, Handle<JSFunction> function)
+  PipelineCompilationJob(ParseInfo* parse_info, Handle<JSFunction> function)
       // Note that the CompilationInfo is not initialized at the time we pass it
       // to the CompilationJob constructor, but it is not dereferenced there.
-      : CompilationJob(isolate, &info_, "TurboFan"),
-        parse_info_(handle(function->shared())),
-        zone_stats_(isolate->allocator()),
-        info_(parse_info_.zone(), &parse_info_, function),
+      : CompilationJob(parse_info->isolate(), &info_, "TurboFan"),
+        parse_info_(parse_info),
+        zone_stats_(parse_info->isolate()->allocator()),
+        info_(parse_info_.get()->zone(), parse_info_.get(), function),
         pipeline_statistics_(CreatePipelineStatistics(info(), &zone_stats_)),
         data_(&zone_stats_, info(), pipeline_statistics_.get()),
         pipeline_(&data_),
@@ -563,7 +563,7 @@ class PipelineCompilationJob final : public CompilationJob {
   Status FinalizeJobImpl() final;
 
  private:
-  ParseInfo parse_info_;
+  std::unique_ptr<ParseInfo> parse_info_;
   ZoneStats zone_stats_;
   CompilationInfo info_;
   std::unique_ptr<PipelineStatistics> pipeline_statistics_;
@@ -1750,8 +1750,17 @@ Handle<Code> Pipeline::GenerateCodeForTesting(
 }
 
 // static
-CompilationJob* Pipeline::NewCompilationJob(Handle<JSFunction> function) {
-  return new PipelineCompilationJob(function->GetIsolate(), function);
+CompilationJob* Pipeline::NewCompilationJob(Handle<JSFunction> function,
+                                            bool has_script) {
+  Isolate* isolate = function->shared()->GetIsolate();

[Michael Starzinger, 2017/02/15 14:51:48]

nit: The isolate is only used for the handle allocation below the work involved
is exactly the same is if were were to just use the general handle constructor,
but it's easier to read:

Handle<SharedFunctionInfo> shared(function->shared());

[mvstanton, 2017/02/15 15:18:46]

Done.

+  Handle<SharedFunctionInfo> shared = handle(function->shared(), isolate);
+  ParseInfo* p;

[Michael Starzinger, 2017/02/15 14:51:48]

nit: s/p/parse_info/

[mvstanton, 2017/02/15 15:18:47]

Done.

+  if (!has_script) {
+    p = ParseInfo::AllocateWithoutScript(shared);
+  } else {
+    p = new ParseInfo(shared);
+  }
+  return new PipelineCompilationJob(p, function);
 }
 
 // static