Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(715)

Issue 2684033006: Move _fatal from dart:core to dart:_internal (Closed)

Created:
3 years, 10 months ago by Kevin Millikin (Google)
Modified:
3 years, 10 months ago
Reviewers:
kustermann
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Move _fatal from dart:core to dart:_internal _fatal was a private function in dart:core which was called from a different library (dart:async). It's not clear how it was supposed to work or if it even did. The uses in dart:async don't appear to be covered by tests. Move it to dart:_internal which exists exactly for sharing things between the dart: libraries. BUG= R=kustermann@google.com Committed: https://github.com/dart-lang/sdk/commit/fdb4c100e0914677fd274b0deff91e6c818a6878

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M runtime/lib/async_patch.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M runtime/lib/core_patch.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M runtime/lib/internal_patch.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/lib/object.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M runtime/vm/bootstrap_natives.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Kevin Millikin (Google)
3 years, 10 months ago (2017-02-09 11:41:32 UTC) #2
kustermann
LGTM, thanks!
3 years, 10 months ago (2017-02-09 11:43:18 UTC) #3
Kevin Millikin (Google)
3 years, 10 months ago (2017-02-09 11:46:59 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fdb4c100e0914677fd274b0deff91e6c818a6878 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698