runtime/vm/ast_transformer.cc - Issue 2683973002: Handle type literals correctly with deferred loading and await.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/ast_transformer.cc

Issue 2683973002: Handle type literals correctly with deferred loading and await. (Closed)

Patch Set: correct fix Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/ast_transformer.cc

diff --git a/runtime/vm/ast_transformer.cc b/runtime/vm/ast_transformer.cc

index fa1028d7e629ad3567833bcb143ac3ff29359ff5..40d27852f858cd6817c17db511a98ff8ed29a8bd 100644

--- a/runtime/vm/ast_transformer.cc

+++ b/runtime/vm/ast_transformer.cc

@@ -119,7 +119,11 @@ void AwaitTransformer::VisitLiteralNode(LiteralNode* node) {

void AwaitTransformer::VisitTypeNode(TypeNode* node) {

- result_ = new (Z) TypeNode(node->token_pos(), node->type());

+ if (node->is_deferred_reference()) {

hausner 2017/02/08 22:41:00 Maybe a short comment and/or pointer to the issue

Florian Schneider 2017/02/08 23:25:23 Done.

+ result_ = MakeName(node);

+ } else {

+ result_ = node;

+ }

}

« no previous file with comments | « runtime/vm/ast.h ('k') | runtime/vm/parser.cc » ('j') | no next file with comments »