Enable startup tracing from command line flags in components/tracing

content/app/content_main_runner.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/public/app/content_main_runner.h"
 
 #include <stddef.h>
 #include <stdlib.h>
 #include <string.h>
 
@@ skipping 23 matching lines @@
 #include "base/process/launch.h"
 #include "base/process/memory.h"
 #include "base/process/process.h"
 #include "base/process/process_handle.h"
 #include "base/profiler/scoped_tracker.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
 #include "base/strings/stringprintf.h"
 #include "base/trace_event/trace_event.h"
 #include "build/build_config.h"
-#include "components/tracing/browser/trace_config_file.h"
-#include "components/tracing/common/trace_to_console.h"
-#include "components/tracing/common/tracing_switches.h"
+#include "components/tracing/common/trace_startup.h"
 #include "content/app/mojo/mojo_init.h"
 #include "content/browser/browser_main.h"
 #include "content/browser/renderer_host/render_process_host_impl.h"
 #include "content/browser/utility_process_host_impl.h"
 #include "content/common/set_process_title.h"
 #include "content/common/url_schemes.h"
 #include "content/gpu/in_process_gpu_thread.h"
 #include "content/public/app/content_main.h"
 #include "content/public/app/content_main_delegate.h"
 #include "content/public/browser/content_browser_client.h"
@@ skipping 546 matching lines @@
 #if defined(OS_WIN)
     // Route stdio to parent console (if any) or create one.
     if (command_line.HasSwitch(switches::kEnableLogging))
       base::RouteStdioToConsole(true);
 #endif
 
 #if !defined(OS_ANDROID)
     // Enable startup tracing asap to avoid early TRACE_EVENT calls being
     // ignored. For Android, startup tracing is enabled in an even earlier place
     // content/app/android/library_loader_hooks.cc.
-    if (command_line.HasSwitch(switches::kTraceStartup)) {
-      base::trace_event::TraceConfig trace_config(
-          command_line.GetSwitchValueASCII(switches::kTraceStartup),
-          base::trace_event::RECORD_UNTIL_FULL);
-      base::trace_event::TraceLog::GetInstance()->SetEnabled(
-          trace_config,
-          base::trace_event::TraceLog::RECORDING_MODE);
-    } else if (command_line.HasSwitch(switches::kTraceToConsole)) {
-      base::trace_event::TraceConfig trace_config =
-          tracing::GetConfigForTraceToConsole();
-      LOG(ERROR) << "Start " << switches::kTraceToConsole
-                 << " with CategoryFilter '"
-                 << trace_config.ToCategoryFilterString() << "'.";
-      base::trace_event::TraceLog::GetInstance()->SetEnabled(
-          trace_config,
-          base::trace_event::TraceLog::RECORDING_MODE);
-    } else if (process_type != switches::kZygoteProcess &&
-               process_type != switches::kRendererProcess) {
-      if (tracing::TraceConfigFile::GetInstance()->IsEnabled()) {
-        // This checks kTraceConfigFile switch.
-        base::trace_event::TraceLog::GetInstance()->SetEnabled(
-            tracing::TraceConfigFile::GetInstance()->GetTraceConfig(),
-            base::trace_event::TraceLog::RECORDING_MODE);
-      }
-    }
+    // Zygote process does not have file thread and renderer process on Win10
+    // cannot access the file system.

[nasko, 2017/02/15 19:18:58]

Is that the real reason? Utility processes also don't have filesystem access.

[ssid, 2017/02/15 19:41:34]

Um Then I would guess startup tracing does not work well in Utility process.
This was the reason given for adding this condition in the CL here:
https://codereview.chromium.org/1212893009#msg6

I do not want to make functional changes for this case in this CL since I
haven't tested. I am planning to add a browsertest for startup tracing this
week. I will fix this case along with the test.

+    bool can_access_file_system = (process_type != switches::kZygoteProcess &&
+                                   process_type != switches::kRendererProcess);
+    tracing::EnableStartupTracingIfNeeded(can_access_file_system);
 #endif  // !OS_ANDROID
 
 #if defined(OS_WIN)
     // Enable exporting of events to ETW if requested on the command line.
     if (command_line.HasSwitch(switches::kTraceExportEventsToETW))
       base::trace_event::TraceEventETWExport::EnableETWExport();
 #endif  // OS_WIN
 
 #if !defined(OS_ANDROID)
     // Android tracing started at the beginning of the method.
@@ skipping 225 matching lines @@
 
   DISALLOW_COPY_AND_ASSIGN(ContentMainRunnerImpl);
 };
 
 // static
 ContentMainRunner* ContentMainRunner::Create() {
   return new ContentMainRunnerImpl();
 }
 
 }  // namespace content