src/objects-debug.cc - Issue 2683903002: Fix missing cases of empty_string canonicalization

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects-debug.cc

Issue 2683903002: Fix missing cases of empty_string canonicalization (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/objects-debug.cc

diff --git a/src/objects-debug.cc b/src/objects-debug.cc

index 4dcdb5dd1f173923ab9f4290ace46be8d65b8d58..04bade24a223ef8e5d198e7088044a88547c5f96 100644

--- a/src/objects-debug.cc

+++ b/src/objects-debug.cc

@@ -552,6 +552,7 @@ void JSMessageObject::JSMessageObjectVerify() {

void String::StringVerify() {

CHECK(IsString());

CHECK(length() >= 0 && length() <= Smi::kMaxValue);

+ CHECK(length() > 0 || this == GetHeap()->empty_string());

Benedikt Meurer 2017/02/08 03:53:08 Nit: use CHECK_IMPLIES here.

if (IsInternalizedString()) {

CHECK(!GetHeap()->InNewSpace(this));

}