Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Issue 2683893002: Make corelib_strong tests strong-mode compliant (Closed)

Created:
3 years, 10 months ago by Bill Hesse
Modified:
3 years, 10 months ago
Reviewers:
Leaf, Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -70 lines) Patch
M tests/corelib_strong/apply3_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/corelib_strong/const_list_remove_range_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/corelib_strong/const_list_set_range_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/corelib_strong/iterable_skip_test.dart View 1 chunk +10 lines, -10 lines 1 comment Download
M tests/corelib_strong/iterable_skip_while_test.dart View 1 chunk +11 lines, -11 lines 0 comments Download
M tests/corelib_strong/iterable_take_test.dart View 1 chunk +11 lines, -11 lines 0 comments Download
M tests/corelib_strong/iterable_take_while_test.dart View 1 chunk +11 lines, -11 lines 0 comments Download
M tests/corelib_strong/list_fill_range_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/corelib_strong/list_get_range_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/corelib_strong/list_insert_all_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/corelib_strong/list_map_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/corelib_strong/list_remove_range_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/corelib_strong/list_replace_range_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/corelib_strong/list_set_all_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/corelib_strong/list_set_range_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/corelib_strong/list_sublist_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/corelib_strong/set_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/corelib_strong/shuffle_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/corelib_strong/sort_test.dart View 1 chunk +3 lines, -1 line 1 comment Download
M tests/corelib_strong/splay_tree_from_iterable_test.dart View 4 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Bill Hesse
3 years, 10 months ago (2017-02-08 01:22:25 UTC) #2
Leaf
lgtm https://codereview.chromium.org/2683893002/diff/1/tests/corelib_strong/iterable_skip_test.dart File tests/corelib_strong/iterable_skip_test.dart (right): https://codereview.chromium.org/2683893002/diff/1/tests/corelib_strong/iterable_skip_test.dart#newcode218 tests/corelib_strong/iterable_skip_test.dart:218: var dynamicSkip0 = set2.skip(0); Alternatively, could make the ...
3 years, 10 months ago (2017-02-08 02:03:49 UTC) #3
Bill Hesse
3 years, 10 months ago (2017-02-08 02:29:34 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
19a414db7cc1a8818e1d3b24a615f0760d5be500 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698