Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: third_party/WebKit/Source/core/testing/Internals.h

Issue 2683853005: bindings: Make some value iterator properties aliases to Array.prototype functions (Closed)
Patch Set: Remove constexpr from Internals.h to fix the Android build Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/testing/Internals.h
diff --git a/third_party/WebKit/Source/core/testing/Internals.h b/third_party/WebKit/Source/core/testing/Internals.h
index e05a5b6157ae06aeba20a41a03a5a45c50c29cec..71751dd3725cc7a2fc7c96c4b5cc3fc633693c01 100644
--- a/third_party/WebKit/Source/core/testing/Internals.h
+++ b/third_party/WebKit/Source/core/testing/Internals.h
@@ -28,7 +28,6 @@
#define Internals_h
#include "bindings/core/v8/ExceptionState.h"
-#include "bindings/core/v8/Iterable.h"
#include "bindings/core/v8/ScriptPromise.h"
#include "bindings/core/v8/ScriptState.h"
#include "bindings/core/v8/ScriptValue.h"
@@ -48,6 +47,8 @@ class ClientRect;
class ClientRectList;
class DOMArrayBuffer;
class DOMPoint;
+class DOMWindow;
+class Dictionary;
class DictionaryTest;
class Document;
class DocumentMarker;
@@ -77,8 +78,7 @@ class StaticNodeTypeList;
using StaticNodeList = StaticNodeTypeList<Node>;
class Internals final : public GarbageCollected<Internals>,
- public ScriptWrappable,
- public ValueIterable<int> {
+ public ScriptWrappable {
DEFINE_WRAPPERTYPEINFO();
public:
@@ -493,6 +493,10 @@ class Internals final : public GarbageCollected<Internals>,
bool isUseCounted(Document*, uint32_t feature);
bool isCSSPropertyUseCounted(Document*, const String&);
+ // Used by the iterable<>.
+ unsigned length() const { return 5; }
+ int anonymousIndexedGetter(uint32_t index) const { return index * index; }
+
String unscopableAttribute();
String unscopableMethod();
@@ -541,8 +545,6 @@ class Internals final : public GarbageCollected<Internals>,
ExceptionState&);
Member<InternalRuntimeFlags> m_runtimeFlags;
Member<Document> m_document;
-
- IterationSource* startIteration(ScriptState*, ExceptionState&) override;
};
} // namespace blink
« no previous file with comments | « third_party/WebKit/Source/core/dom/NodeList.cpp ('k') | third_party/WebKit/Source/core/testing/Internals.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698