third_party/WebKit/Source/core/css/cssom/CSSUnparsedValueTest.cpp - Issue 2683853005: bindings: Make some value iterator properties aliases to Array.prototype functions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/cssom/CSSUnparsedValueTest.cpp

Issue 2683853005: bindings: Make some value iterator properties aliases to Array.prototype functions (Closed)

Patch Set: Remove constexpr from Internals.h to fix the Android build Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/cssom/CSSUnparsedValueTest.cpp

diff --git a/third_party/WebKit/Source/core/css/cssom/CSSUnparsedValueTest.cpp b/third_party/WebKit/Source/core/css/cssom/CSSUnparsedValueTest.cpp

index 33353df26693dae1c0247876c9a64653128adf24..82aa8e3b92aa924d093b57979cc0f061235e3a5e 100644

--- a/third_party/WebKit/Source/core/css/cssom/CSSUnparsedValueTest.cpp

+++ b/third_party/WebKit/Source/core/css/cssom/CSSUnparsedValueTest.cpp

@@ -26,13 +26,13 @@ TEST(CSSUnparsedValueTest, EmptyList) {

HeapVector<StringOrCSSVariableReferenceValue> fragments;

CSSUnparsedValue* unparsedValue = CSSUnparsedValue::create(fragments);

- EXPECT_EQ(unparsedValue->size(), 0UL);

+ EXPECT_EQ(unparsedValue->length(), 0UL);

}

TEST(CSSUnparsedValueTest, ListOfStrings) {

CSSUnparsedValue* unparsedValue = CSSUnparsedValue::fromString("string");

- EXPECT_EQ(unparsedValue->size(), 1UL);

+ EXPECT_EQ(unparsedValue->length(), 1UL);

EXPECT_TRUE(unparsedValue->fragmentAtIndex(0).isString());

EXPECT_FALSE(unparsedValue->fragmentAtIndex(0).isNull());

@@ -49,7 +49,7 @@ TEST(CSSUnparsedValueTest, ListOfCSSVariableReferenceValues) {

CSSUnparsedValue* unparsedValue =

unparsedValueFromCSSVariableReferenceValue(variableReferenceValue);

- EXPECT_EQ(unparsedValue->size(), 1UL);

+ EXPECT_EQ(unparsedValue->length(), 1UL);

EXPECT_FALSE(unparsedValue->fragmentAtIndex(0).isString());

EXPECT_FALSE(unparsedValue->fragmentAtIndex(0).isNull());

@@ -73,7 +73,7 @@ TEST(CSSUnparsedValueTest, MixedList) {

CSSUnparsedValue* unparsedValue = CSSUnparsedValue::create(fragments);

- EXPECT_EQ(unparsedValue->size(), fragments.size());

+ EXPECT_EQ(unparsedValue->length(), fragments.size());

EXPECT_TRUE(unparsedValue->fragmentAtIndex(0).isString());

EXPECT_FALSE(unparsedValue->fragmentAtIndex(0).isCSSVariableReferenceValue());