Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Unified Diff: third_party/WebKit/Source/core/css/cssom/CSSUnparsedValue.h

Issue 2683853005: bindings: Make some value iterator properties aliases to Array.prototype functions (Closed)
Patch Set: Remove constexpr from Internals.h to fix the Android build Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/cssom/CSSUnparsedValue.h
diff --git a/third_party/WebKit/Source/core/css/cssom/CSSUnparsedValue.h b/third_party/WebKit/Source/core/css/cssom/CSSUnparsedValue.h
index ad98b50b40bca403c700cb825747836db6421e3c..b41a2837b4ca361e81ed11c9119e7a9a189641c5 100644
--- a/third_party/WebKit/Source/core/css/cssom/CSSUnparsedValue.h
+++ b/third_party/WebKit/Source/core/css/cssom/CSSUnparsedValue.h
@@ -5,7 +5,6 @@
#ifndef CSSUnparsedValue_h
#define CSSUnparsedValue_h
-#include "bindings/core/v8/Iterable.h"
#include "bindings/core/v8/StringOrCSSVariableReferenceValue.h"
#include "core/css/CSSVariableReferenceValue.h"
#include "core/css/cssom/CSSStyleValue.h"
@@ -13,9 +12,7 @@
namespace blink {
-class CORE_EXPORT CSSUnparsedValue final
- : public CSSStyleValue,
- public ValueIterable<StringOrCSSVariableReferenceValue> {
+class CORE_EXPORT CSSUnparsedValue final : public CSSStyleValue {
WTF_MAKE_NONCOPYABLE(CSSUnparsedValue);
DEFINE_WRAPPERTYPEINFO();
@@ -31,11 +28,11 @@ class CORE_EXPORT CSSUnparsedValue final
StyleValueType type() const override { return UnparsedType; }
- StringOrCSSVariableReferenceValue fragmentAtIndex(int index) const {
+ StringOrCSSVariableReferenceValue fragmentAtIndex(uint32_t index) const {
return m_fragments.at(index);
}
- size_t size() const { return m_fragments.size(); }
+ size_t length() const { return m_fragments.size(); }
DEFINE_INLINE_VIRTUAL_TRACE() {
visitor->trace(m_fragments);
@@ -54,8 +51,6 @@ class CORE_EXPORT CSSUnparsedValue final
return create(fragments);
}
- IterationSource* startIteration(ScriptState*, ExceptionState&) override;
-
FRIEND_TEST_ALL_PREFIXES(CSSUnparsedValueTest, ListOfStrings);
FRIEND_TEST_ALL_PREFIXES(CSSUnparsedValueTest,
ListOfCSSVariableReferenceValues);

Powered by Google App Engine
This is Rietveld 408576698